[Qemu-devel] Remove qemu-fast warning

[Qemu-devel] Remove qemu-fast warning

[Paul Brook]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

The attached patch removes the warning about lack of static SDL. This is only 
userd by qemu-fast, which isn't build by default. Anyone building qemu-fast 
should know what they're doing anyway. The current warning just confuses 
people.

Please apply.

Paul

[-- Attachment #2: p --]
[-- Type: text/x-diff, Size: 606 bytes --]

Index: configure
===================================================================
RCS file: /cvsroot/qemu/qemu/configure,v
retrieving revision 1.56
diff -u -p -r1.56 configure
--- configure	19 Feb 2005 17:24:28 -0000	1.56
+++ configure	28 Feb 2005 20:22:32 -0000
@@ -427,9 +427,6 @@ fi
 if test $sdl_too_old = "yes"; then
 echo "-> Your SDL version is too old - please upgrade to have FFplay/SDL support"
 fi
-if test "$sdl_static" = "no"; then
-  echo "WARNING: cannot compile statically with SDL - qemu-fast won't have a graphical output"
-fi
 
 config_mak="config-host.mak"
 config_h="config-host.h"

Re: [Qemu-devel] Remove qemu-fast warning

[Darryl Dixon]

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]

Incidentally to this, I discovered that qemu will both ./configure (with
--target-list=i386-softmmu) and make && make install fine with no
sdl-devel installed, and will run fine, but will not have any graphical
output.  I assume that this is technically a bug, as it doesn't warn at
any point that this will be the case.

Cheers,
D

On Mon, 2005-02-28 at 21:07 +0000, Paul Brook wrote:

>The attached patch removes the warning about lack of static SDL. This is only 
>userd by qemu-fast, which isn't build by default. Anyone building qemu-fast 
>should know what they're doing anyway. The current warning just confuses 
>people.
>
>Please apply.
>
>Paul
>_______________________________________________
>Qemu-devel mailing list
>Qemu-devel@nongnu.org
>http://lists.nongnu.org/mailman/listinfo/qemu-devel

[-- Attachment #2: Type: text/html, Size: 1501 bytes --]

Re: [Qemu-devel] Remove qemu-fast warning

[Jim C. Brown]

On Tue, Mar 01, 2005 at 10:57:26AM +1300, Darryl Dixon wrote:
> Incidentally to this, I discovered that qemu will both ./configure (with
> --target-list=i386-softmmu) and make && make install fine with no
> sdl-devel installed, and will run fine, but will not have any graphical
> output.  I assume that this is technically a bug, as it doesn't warn at
> any point that this will be the case.
> 
> Cheers,
> D
> 

The bug would be that it doesn't warn. It should state that there will be no
graphical output if it can't find libsdl-devel. (Tho you should have gotten
a warning that SDL was not detected period.)

Does this bug occur w/o Paul Brooks patch as well?

qemu needs libsdl-devel in order to compile correctly and link to the libsdl
library, in case that was not made clear before.

> On Mon, 2005-02-28 at 21:07 +0000, Paul Brook wrote:
> 
> >The attached patch removes the warning about lack of static SDL. This is only 
> >userd by qemu-fast, which isn't build by default. Anyone building qemu-fast 
> >should know what they're doing anyway. The current warning just confuses 
> >people.
> >
> >Please apply.
> >
> >Paul
> >_______________________________________________
> >Qemu-devel mailing list
> >Qemu-devel@nongnu.org
> >http://lists.nongnu.org/mailman/listinfo/qemu-devel

> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel


-- 
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.

Re: [Qemu-devel] Remove qemu-fast warning

[Darryl Dixon]

[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]

Sorry, I wasn't very clear in the previous post.  I was referring to the
current Qemu CVS *not* including Paul Brook's patch.  The ./configure
will note that SDL support = no, but it will happily make && make
install with no errors and will run, albeit without any graphical
output.

Cheers,
D

On Mon, 2005-02-28 at 18:05 -0500, Jim C. Brown wrote:

>On Tue, Mar 01, 2005 at 10:57:26AM +1300, Darryl Dixon wrote:
>> Incidentally to this, I discovered that qemu will both ./configure (with
>> --target-list=i386-softmmu) and make && make install fine with no
>> sdl-devel installed, and will run fine, but will not have any graphical
>> output.  I assume that this is technically a bug, as it doesn't warn at
>> any point that this will be the case.
>> 
>> Cheers,
>> D
>> 
>
>The bug would be that it doesn't warn. It should state that there will be no
>graphical output if it can't find libsdl-devel. (Tho you should have gotten
>a warning that SDL was not detected period.)
>
>Does this bug occur w/o Paul Brooks patch as well?
>
>qemu needs libsdl-devel in order to compile correctly and link to the libsdl
>library, in case that was not made clear before.
>
>> On Mon, 2005-02-28 at 21:07 +0000, Paul Brook wrote:
>> 
>> >The attached patch removes the warning about lack of static SDL. This is only 
>> >userd by qemu-fast, which isn't build by default. Anyone building qemu-fast 
>> >should know what they're doing anyway. The current warning just confuses 
>> >people.
>> >
>> >Please apply.
>> >
>> >Paul
>> >_______________________________________________
>> >Qemu-devel mailing list
>> >Qemu-devel@nongnu.org
>> >http://lists.nongnu.org/mailman/listinfo/qemu-devel
>
>> _______________________________________________
>> Qemu-devel mailing list
>> Qemu-devel@nongnu.org
>> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>
>

[-- Attachment #2: Type: text/html, Size: 3443 bytes --]