From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DCW68-0004ah-VS for qemu-devel@nongnu.org; Sat, 19 Mar 2005 00:02:06 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DCW5k-0004PN-5I for qemu-devel@nongnu.org; Sat, 19 Mar 2005 00:01:44 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DCW5j-0004Ka-0d for qemu-devel@nongnu.org; Sat, 19 Mar 2005 00:01:39 -0500 Received: from [128.8.10.163] (helo=po1.wam.umd.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DCVPC-0005n9-Pw for qemu-devel@nongnu.org; Fri, 18 Mar 2005 23:17:42 -0500 Received: from jbrown.mylinuxbox.org (jma-box.student.umd.edu [129.2.237.180]) by po1.wam.umd.edu (8.12.10/8.12.10) with ESMTP id j2J4Hfpo015874 for ; Fri, 18 Mar 2005 23:17:42 -0500 (EST) Date: Fri, 18 Mar 2005 23:17:41 -0500 From: "Jim C. Brown" Message-ID: <20050319041741.GA16957@jbrown.mylinuxbox.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline Subject: [Qemu-devel] make stdio monitor default Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline For all users of qemu, with the exception of those who use Windows as the host OS, it is better to make the monitor stdio by default. It is easier to debug bugs in qemu when the monitor and the guest screen can be seen at the same time, having qemu load the monitor in the terminal where qemu is started makes it easy to find and figure out how to use (a lot of new users seem to not know about the monitor until told so), logging of monitor output (state of qemu guest registers, network status, etc) is a lot easier, etc. The only reason that qemu has the vc monitor as the default is because on Windows, qemu either has to be a console app (and thus has very slow output) or else has to specifically request a console to be used to route stdio to (involving Windows specific code). Even if this was done, a second console window tends to be very confusing for new users, so it may do more harm than good. I agree that vc should be the default for Windows, but that for Linux (and Unix) having stdio default would be better. (This is of course a policy decision, not a coding or feature one, as both stdio and vc can be used in either Linux or Windows host). It would be nice to get other opinions on this. The only objection I see to this would be that making vc default only for Windows would give qemu the impression of having different interfaces for different host OSes. I am not sure how this could be dealt with, but I am thinking about it. I have attached a very short patch that makes stdio monitor the default except when qemu is compiled on windows (then the vc monitor (the ctrl-alt-2 version)) is the default. -- Infinite complexity begets infinite beauty. Infinite precision begets infinite perfection. --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="vl.diff" --- vl.c.old Fri Mar 18 23:01:24 2005 +++ vl.c Fri Mar 18 23:02:03 2005 @@ -3031,7 +3031,11 @@ has_cdrom = 1; cyls = heads = secs = 0; translation = BIOS_ATA_TRANSLATION_AUTO; +#ifndef _WIN32 pstrcpy(monitor_device, sizeof(monitor_device), "vc"); +#else + pstrcpy(monitor_device, sizeof(monitor_device), "stdio"); +#endif pstrcpy(serial_devices[0], sizeof(serial_devices[0]), "vc"); for(i = 1; i < MAX_SERIAL_PORTS; i++) --9jxsPFA5p3P2qPhR--