From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DCytV-0000n8-RZ
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 06:46:58 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DCytR-0000lz-UA
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 06:46:55 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DCytR-0000k6-I8
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 06:46:53 -0500
Received: from [65.74.133.9] (helo=mail.codesourcery.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.34) id 1DCyaU-0004tG-9s
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 06:27:18 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] make stdio monitor default
Date: Sun, 20 Mar 2005 11:26:12 +0000
References: <20050319041741.GA16957@jbrown.mylinuxbox.org>
In-Reply-To: <20050319041741.GA16957@jbrown.mylinuxbox.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200503201126.13115.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: "Jim C. Brown" <jma5@umd.edu>

> I agree that vc should be the default for Windows, but that for Linux (and
> Unix) having stdio default would be better. (This is of course a policy
> decision, not a coding or feature one, as both stdio and vc can be used in
> either Linux or Windows host). It would be nice to get other opinions on 
> this. 

I agree, although I think the proper fix is to move the logic into the 
configure script and make it a configure time option. 
ie ./configure --enable-monitor=foo would set the default.

> --- vl.c.old Fri Mar 18 23:01:24 2005
> +++ vl.c Fri Mar 18 23:02:03 2005
> @@ -3031,7 +3031,11 @@
>      has_cdrom = 1;
>      cyls = heads = secs = 0;
>      translation = BIOS_ATA_TRANSLATION_AUTO;
> +#ifndef _WIN32
>      pstrcpy(monitor_device, sizeof(monitor_device), "vc");
> +#else
> +    pstrcpy(monitor_device, sizeof(monitor_device), "stdio");
> +#endif
>  
>      pstrcpy(serial_devices[0], sizeof(serial_devices[0]), "vc");
>      for(i = 1; i < MAX_SERIAL_PORTS; i++)

Have you tested this patch? It looks like it does the opposite of what you are 
suggesting.

Paul