From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DD6qn-0006bI-4Q
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 15:16:41 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DD6qd-0006Vv-Hw
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 15:16:33 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DD6qd-0006U9-9d
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 15:16:31 -0500
Received: from [128.8.10.163] (helo=po1.wam.umd.edu)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1DD6Wv-0002Nx-QJ
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 14:56:09 -0500
Received: from jbrown.mylinuxbox.org (jma-box.student.umd.edu [129.2.237.180])
	by po1.wam.umd.edu (8.12.10/8.12.10) with ESMTP id j2KJu8Bv003036
	for <qemu-devel@nongnu.org>; Sun, 20 Mar 2005 14:56:09 -0500 (EST)
Date: Sun, 20 Mar 2005 14:56:08 -0500
From: "Jim C. Brown" <jma5@umd.edu>
Subject: Re: [Qemu-devel] make stdio monitor default
Message-ID: <20050320195608.GA11155@jbrown.mylinuxbox.org>
References: <20050319041741.GA16957@jbrown.mylinuxbox.org>
	<200503201126.13115.paul@codesourcery.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200503201126.13115.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Mar 20, 2005 at 11:26:12AM +0000, Paul Brook wrote:
> Have you tested this patch? It looks like it does the opposite of what you are 
> suggesting.
> 
> Paul
> 
> 

Whoops I sent the wrong one. Here is the right version:

--- vl.c.old Fri Mar 18 23:01:24 2005
+++ vl.c Fri Mar 18 23:02:03 2005
@@ -3031,7 +3031,11 @@
     has_cdrom = 1;
     cyls = heads = secs = 0;
     translation = BIOS_ATA_TRANSLATION_AUTO;
+#ifdef _WIN32
     pstrcpy(monitor_device, sizeof(monitor_device), "vc");
+#else
+    pstrcpy(monitor_device, sizeof(monitor_device), "stdio");
+#endif
 
     pstrcpy(serial_devices[0], sizeof(serial_devices[0]), "vc");
     for(i = 1; i < MAX_SERIAL_PORTS; i++)

> I agree, although I think the proper fix is to move the logic into the 
> configure script and make it a configure time option. 
> ie ./configure --enable-monitor=foo would set the default.

Interesting idea. I'll see if I can set this up and send a diff.

-- 
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.