From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DD72u-0002J3-3s
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 15:29:12 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DD72k-0002B4-A6
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 15:29:05 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DD72k-00029b-6J
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 15:29:02 -0500
Received: from [65.74.133.9] (helo=mail.codesourcery.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.34) id 1DD6gv-00033B-MF
	for qemu-devel@nongnu.org; Sun, 20 Mar 2005 15:06:29 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [patch] compiler warning
Date: Sun, 20 Mar 2005 20:06:25 +0000
References: <200503201843.01155.paul@codesourcery.com>
In-Reply-To: <200503201843.01155.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200503202006.25803.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sunday 20 March 2005 18:43, Paul Brook wrote:
> The patch below fixes the following compiler warning:
>
> cpu-exec.c:763: warning: control reaches end of non-void function

Updated version also fixes a similar problem with the SPARC target.

Paul

Index: cpu-exec.c
===================================================================
RCS file: /cvsroot/qemu/qemu/cpu-exec.c,v
retrieving revision 1.51
diff -u -p -r1.51 cpu-exec.c
--- cpu-exec.c 22 Feb 2005 19:27:14 -0000 1.51
+++ cpu-exec.c 20 Mar 2005 20:03:21 -0000
@@ -786,6 +791,8 @@ static inline int handle_cpu_signal(unsi
        do it (XXX: use sigsetjmp) */
     sigprocmask(SIG_SETMASK, old_set, NULL);
     cpu_loop_exit();
+    /* never comes here */
+    return 1;
 }
 #elif defined(TARGET_SPARC)
 static inline int handle_cpu_signal(unsigned long pc, unsigned long address,
@@ -822,6 +829,8 @@ static inline int handle_cpu_signal(unsi
        do it (XXX: use sigsetjmp) */
     sigprocmask(SIG_SETMASK, old_set, NULL);
     cpu_loop_exit();
+    /* never comes here */
+    return 1;
 }
 #elif defined (TARGET_PPC)
 static inline int handle_cpu_signal(unsigned long pc, unsigned long address,