Re: [Qemu-devel] [patch] CPU architecture selection

[Paul Brook <paul@codesourcery.com>]

On Saturday 26 March 2005 20:02, J. Mayer wrote:
> On Sat, 2005-03-26 at 19:46 +0000, Paul Brook wrote:
> > The attached patch adds a -cpu commandline option to qemu to allow the
> > user to select what type of CPU is emulated. It currently only does
> > anything useful for arm targets, but it should be easy to hook other
> > targets into the same mechanism.
> >
> > I implemented the selection as a bitmask. This allows users to select a
> > CPU by the features it provides, and also allows creation of convenient
> > aliases for common CPUs.
>
> there is a cpu_ppc_register function in target-ppc/translate.c which
> does what's needed for emulated PPC selection.
> The CPU is registered from the emulated board definition, ie in
> hw/ppc_prep.c or hw/ppc_chrp.c.
> Your patch conflicts with this code.

Hmm, I hadn't spotted that. I'll see if I can merge them.

> It seems to me that cpu selection should go in board definitions, like
> all the rest of emulated hardware selection, then have nothing to do in
> target-xxx/translate.c.

I'm not sure what you mean.

I guess it makes makes sense for the board to be able to specify the default 
cpu. That's pretty much independent of the rest of the implementation though.
I'd have thought CPU choice should be fairly independent of the rest of the 
hardware. There's also user mode where we don't emulate any system hardware.

Paul