qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Massimo Dal Zotto <dz@debian.org>
To: qemu-devel@nongnu.org
Cc: jma5@umd.edu
Subject: Re: [Qemu-devel] [patch] option -no-tsc for i386 with speedstep
Date: Mon, 25 Apr 2005 19:44:59 +0200	[thread overview]
Message-ID: <20050425174459.GA6115@dizzy.ath.cx> (raw)
In-Reply-To: <20050425170752.GA20078@jbrown.mylinuxbox.org>

On Mon, Apr 25, 2005 at 01:07:52PM -0400, Jim C. Brown wrote:
> 
> I just want to point out that your patches break qemu for almost every
> platform other than i386.
> 
> You probably want to do this, because notsc is only declared for the i386
> platform.
> 
>  int64_t cpu_get_real_ticks(void)
>  {
>      int64_t val;
> +#ifdef __i386__
> +    if (notsc) {
> +	return get_clock();
> +    }
> +#endif
>      asm volatile ("rdtsc" : "=A" (val));
>      return val;
>  }
> 

Correct, I forgot the #ifdef inside that function.

I made also some more tests and it turned out that my patch works but
not as expected. The clock now runs at constant rate at any speedstep
frequency, which is what I wanted, but unfortunately it is always ~20%
slower than wall clock.

I tried also to force different values of ticks_per_sec but it seems
that it has no effects on irq frequency, so there must be something that
I don't understand in the timer code.

Any idea on how to fix this bug?

-- 
Massimo Dal Zotto <dz@debian.org>

  parent reply	other threads:[~2005-04-25 17:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-25 11:15 [Qemu-devel] [patch] option -no-tsc for i386 with speedstep Massimo Dal Zotto
2005-04-25 15:44 ` [Qemu-devel] " Heike C. Zimmerer
2005-04-25 17:07 ` [Qemu-devel] " Jim C. Brown
2005-04-25 17:28   ` Paul Brook
2005-04-25 17:44   ` Massimo Dal Zotto [this message]
2005-04-25 17:47   ` [Qemu-devel] " Heike C. Zimmerer
2005-04-25 18:58 ` [Qemu-devel] " Fabrice Bellard
2005-04-25 20:17   ` Massimo Dal Zotto
2005-04-25 20:24     ` Jonas Maebe
2005-04-25 20:38       ` Filip Navara
2005-04-25 21:03         ` Lionel Ulmer
2005-04-25 22:45         ` Taras Glek
2005-04-25 21:46       ` [Qemu-devel] [patch] option -no-tsc for i386 with speedstep (solved) Massimo Dal Zotto
2005-04-26  6:50         ` Jonas Maebe
2005-04-26  3:03 ` [Qemu-devel] [patch] option -no-tsc for i386 with speedstep Kyle Hayes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050425174459.GA6115@dizzy.ath.cx \
    --to=dz@debian.org \
    --cc=jma5@umd.edu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).