From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DWlXF-00047Z-CV
	for qemu-devel@nongnu.org; Fri, 13 May 2005 21:33:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DWlWz-0003yM-7r
	for qemu-devel@nongnu.org; Fri, 13 May 2005 21:33:29 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DWlWy-0003xt-IT
	for qemu-devel@nongnu.org; Fri, 13 May 2005 21:33:28 -0400
Received: from [65.74.133.9] (helo=mail.codesourcery.com)
	by monty-python.gnu.org with esmtp
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1DWlaR-000211-4D
	for qemu-devel@nongnu.org; Fri, 13 May 2005 21:37:03 -0400
From: Paul Brook <paul@codesourcery.com>
Date: Sat, 14 May 2005 02:29:45 +0100
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-2022-jp"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200505140229.45764.paul@codesourcery.com>
Subject: [Qemu-devel] Fwd: qemu-arm : additional fix around QSUB maybe need
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

----------  Forwarded Message  ----------

Subject: qemu-arm : additional fix around QSUB maybe need
Date: Saturday 14 May 2005 02:26
From: "TAKAGO Daisuke" <takago1129@hotmail.com>
To: paul@codesourcery.com

Dear Paul Brook

Hello!
Thank very much for sending fix-patch to me quickly!!
I noticed that patch applyed to CVS. Then I built qemu-arm from CVS.

I tested saturating instructions(QADD, QSUB).
QADD could execute saturating instruction, but QSUB cound not.
I found the problem points in  op_subl_T0_T1_saturate().

The following is a fix point I think.

----- qemu/op.c (near line 797)
void OPPROTO op_subl_T0_T1_saturate(void)
{
  uint32_t res;

  res = T0 - T1;
  if (((res ^ T0) & SIGNBIT) && ((T0 ^ T1) & SIGNBIT)) {
      env->QF = 1;
      if (T0 & SIGNBIT)
-          T0 = 0x8000000;
+          T0 = 0x80000000;
      else
          T0 = 0x7fffffff;
  }
  else
    T0 = res;

  FORCE_RET();
}
--------------------------------------