From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DdBmV-0005ZF-8i
	for qemu-devel@nongnu.org; Tue, 31 May 2005 14:48:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DdBmO-0005VY-F6
	for qemu-devel@nongnu.org; Tue, 31 May 2005 14:47:58 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DdBmN-0005Sj-J6
	for qemu-devel@nongnu.org; Tue, 31 May 2005 14:47:55 -0400
Received: from [65.74.133.9] (helo=mail.codesourcery.com)
	by monty-python.gnu.org with esmtp
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1DdBcI-0001vp-PJ
	for qemu-devel@nongnu.org; Tue, 31 May 2005 14:37:31 -0400
From: Paul Brook <paul@codesourcery.com>
Date: Tue, 31 May 2005 19:35:34 +0100
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_25KnCs7aK3420Q/"
Message-Id: <200505311935.34621.paul@codesourcery.com>
Subject: [Qemu-devel] Configure check for graphical output
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

--Boundary-00=_25KnCs7aK3420Q/
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

The qemu configure script will silently disable graphical output if it can't 
find a suitable output library (ie. SDL). This is a very common source of 
confusion for people building qemu for the first time.  It's not obvious from 
the configure output that SDL is effectively required for normal operation.

The attached patch changes the default behaviour so that configure will issue 
an error if a user tries configure full system emulation without graphical 
output. It also adds an option to suppress this check for users who know what 
they are doing.

Paul


--Boundary-00=_25KnCs7aK3420Q/
Content-Type: text/x-diff;
  charset="us-ascii";
  name="patch.qemu_gfx"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
	filename="patch.qemu_gfx"

Index: configure
===================================================================
RCS file: /cvsroot/qemu/qemu/configure,v
retrieving revision 1.66
diff -u -p -r1.66 configure
--- configure	28 Apr 2005 20:41:53 -0000	1.66
+++ configure	31 May 2005 17:59:51 -0000
@@ -84,6 +84,7 @@ linux="no"
 kqemu="no"
 kernel_path=""
 cocoa="no"
+check_gfx="yes"
 
 # OS specific
 targetos=`uname -s`
@@ -186,6 +187,8 @@ for opt do
   ;; 
   --enable-cocoa) cocoa="yes" ; sdl="no"
   ;; 
+  --disable-gfx-check) check_gfx="no"
+  ;;
   esac
 done
 
@@ -604,6 +607,14 @@ if expr $target : '.*-user' > /dev/null 
   target_user_only="yes"
 fi
 
+if test "$target_user_only" = "no" -a "$check_gfx" = "yes" \
+	-a "$sdl" = "no" -a "$cocoa" = "no" ; then
+    echo "ERROR: QEMU requires SDL or Cocoa for graphical output"
+    echo "To build QEMU with graphical output configure with --disable-gfx-check"
+    echo "Note that this will disable all output from the virtual graphics card."
+    exit 1;
+fi
+
 #echo "Creating $config_mak, $config_h and $target_dir/Makefile"
 
 mkdir -p $target_dir

--Boundary-00=_25KnCs7aK3420Q/--