From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dw4fa-0000lZ-Bv for qemu-devel@nongnu.org; Fri, 22 Jul 2005 17:02:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dw4fY-0000kj-5f for qemu-devel@nongnu.org; Fri, 22 Jul 2005 17:02:57 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dw4db-0007zJ-8C for qemu-devel@nongnu.org; Fri, 22 Jul 2005 17:00:55 -0400 Received: from [217.147.80.44] (helo=cel.leo) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dw4H2-0001PL-2I for qemu-devel@nongnu.org; Fri, 22 Jul 2005 16:37:36 -0400 Date: Fri, 22 Jul 2005 19:14:55 +0100 From: Paul LeoNerd Evans Subject: Re: [Qemu-devel] Anyone familiar with the slirp code? Message-ID: <20050722181455.GD3558@cel.leo> References: <20050722155125.GC3558@cel.leo> <1122050833.6034.400.camel@aragorn> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zbGR4y+acU1DwHSi" Content-Disposition: inline In-Reply-To: <1122050833.6034.400.camel@aragorn> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: jhoger@pobox.com, qemu-devel@nongnu.org --zbGR4y+acU1DwHSi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 22, 2005 at 09:47:13AM -0700, John R. Hogerhuis wrote: > I don't think the original author anticipated or cared about slirp being > ported to a 64-bit processor. I won't speak for the quality of the code > in general, but on a 32-bit machine the pointer size is 32-bit. It's > perfectly safe on that platform to use any 32-bit spot as a hidey hole > for your cookies. Well put.. :) > Just go for it. The slirp code was imported into qemu. At this point > you're probably as much an expert as anyone. There is no upstream > maintainer for the code either, I looked and found and asked the last > sucker that had maintained it for a bit, and he just wanted to unload > it. Well, in this case, it is almost worth pondering if a complete =66rom-the-top rewrite is required... It might be easiest to look at what the code is meant to do, from a high level, and re-implement from scratch. This way, all the required features can be put in from the beginning, no extra stuff that's not required, and so on... I expect large amounts of the code can be kept and modified, and the general layout will remain, but a lot of the data structures will have to go... > If you fix it though, be prepared for the fact that you will be the new > expert ;-) Hhhmmmm.... I have numerous projects I'm already working on; adding one more always gets tricky... But we'll see how things pan out... > One thing I'd like to see long term is to completely remove the NAT code > and replace it with something more modern and robust like netfilter. > That would give us a lot of nice application level gateways (nat > modules) for important protocols, and some tweakable firewall settings > for user-net. >=20 > While I'm wishing, in fact it would be a nice feature in general for > QEMU to have a built in firewall pointed at each host with fairly > minimal permissions by default. A windows machine on your network is a > windows machine on your network, virtual or not :-) Well, as I said above, this sort of thing could be implemented with a re-write.... Perhaps we could borrow some of the "iptables" code from the Linux kernel, and use that..? It would be quite cool, I think, to have something similar to iptables built into qemu... --=20 Paul "LeoNerd" Evans leonerd@leonerd.org.uk ICQ# 4135350 | Registered Linux# 179460 http://www.leonerd.org.uk/ --zbGR4y+acU1DwHSi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFC4TefvcPg11V/1hgRAv3gAJ9TQDLDUq+KReARiiLFMFiRPEOuIQCeMYKm G9zDSXvctmfPuduTWyhXM/4= =rKy7 -----END PGP SIGNATURE----- --zbGR4y+acU1DwHSi--