From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [patch] Byte swapping bug in arm semihosting
Date: Sat, 13 Aug 2005 16:08:03 +0100 [thread overview]
Message-ID: <200508131608.04067.paul@codesourcery.com> (raw)
The patch below fixes a duplicate byte swap in the arm semihosting
implementation. ARG(x) already does the endian correction.
Paul
Index: linux-user//arm-semi.c
===================================================================
RCS file: /cvsroot/qemu/qemu/linux-user/arm-semi.c,v
retrieving revision 1.3
diff -u -p -r1.3 arm-semi.c
--- linux-user//arm-semi.c 13 May 2005 22:42:37 -0000 1.3
+++ linux-user//arm-semi.c 13 Aug 2005 15:05:30 -0000
@@ -178,7 +178,7 @@ uint32_t do_arm_semihosting(CPUState *en
ts->heap_limit = limit;
}
- ptr = (uint32_t *)tswap32(ARG(0));
+ ptr = (uint32_t *)ARG(0);
ptr[0] = tswap32(ts->heap_base);
ptr[1] = tswap32(ts->heap_limit);
ptr[2] = tswap32(ts->stack_base);
reply other threads:[~2005-08-13 15:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508131608.04067.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).