From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ei0Di-0005pP-7y
	for qemu-devel@nongnu.org; Thu, 01 Dec 2005 21:00:18 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ei0Dg-0005pA-Jv
	for qemu-devel@nongnu.org; Thu, 01 Dec 2005 21:00:17 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ei0Dg-0005p7-I7
	for qemu-devel@nongnu.org; Thu, 01 Dec 2005 21:00:16 -0500
Received: from [65.74.133.11] (helo=mail.codesourcery.com)
	by monty-python.gnu.org with esmtp
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1Ei0Dg-0002Wk-2L
	for qemu-devel@nongnu.org; Thu, 01 Dec 2005 21:00:16 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Fri, 2 Dec 2005 02:00:03 +0000
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200512020200.04675.paul@codesourcery.com>
Subject: [Qemu-devel] [patch] Arm mulxy bug
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

The patch below fixes a bug in the implementation of the Arm mulxy 
instruction.

Paul

=== target-arm/translate.c
==================================================================
--- target-arm/translate.c	(revision 1887)
+++ target-arm/translate.c	(local)
@@ -1021,11 +1021,11 @@
 
 static inline void gen_mulxy(int x, int y)
 {
-    if (x & 2)
+    if (x)
         gen_op_sarl_T0_im(16);
     else
         gen_op_sxth_T0();
-    if (y & 1)
+    if (y)
         gen_op_sarl_T1_im(16);
     else
         gen_op_sxth_T1();