Re: [Qemu-devel] [PATCH] Fix to gdb - wrong translation block invalidated when setting gdb breakpoints

[Mulyadi Santosa <a_mulyadi@softhome.net>]

Hello Andre....

> breakpoint was hit. I finally tracked down the problem to
> exec.c:breakpoint_invalidate. The problem is that
> breakpoint_invalidate, which is supposed to invalidate the
> translation block for the address you want to break at, was
> actualling invalidating the translation block for the base address of
> the page that contained your breakpoint address. The fix is actually
> very simple and is attached below.

Thanks for the patch :) I will test the patch ASAP. Anyway, while the 
fix seems "simple", I am sure it wasn't easy to track down the real 
problem. Checking briefly (by eye, not via debugger or tons of printf() 
), one will skip those lines because he/she will think the function  is 
invalidating the correct physical address (returned 
cpu_get_phys_page_debug() ). Great work!

NB: Althought it is a bit late, but it's never too late...Merry 
Christmast!

regards

Mulyadi