[Qemu-devel] [PATCH] Minor mips-related patchlet

[Qemu-devel] [PATCH] Minor mips-related patchlet

[Thiemo Seufer]

Hello All,

this adds a missing prototype and a store function template which is
apparently unused but looks like a good thing to have around (other
ports have it).


Thiemo


Index: target-mips/op_mem.c
===================================================================
RCS file: /sources/qemu/qemu/target-mips/op_mem.c,v
retrieving revision 1.2
diff -u -p -r1.2 op_mem.c
--- target-mips/op_mem.c	5 Dec 2005 19:59:36 -0000	1.2
+++ target-mips/op_mem.c	15 Feb 2006 12:38:30 -0000
@@ -107,6 +107,8 @@ void glue(op_ll, MEMSUFFIX) (void)
     RETURN();
 }
 
+extern void dump_sc (void);
+
 void glue(op_sc, MEMSUFFIX) (void)
 {
     CALL_FROM_TB0(dump_sc);
Index: target-mips/op_template.c
===================================================================
RCS file: /sources/qemu/qemu/target-mips/op_template.c,v
retrieving revision 1.1
diff -u -p -r1.1 op_template.c
--- target-mips/op_template.c	2 Jul 2005 14:57:14 -0000	1.1
+++ target-mips/op_template.c	15 Feb 2006 12:38:30 -0000
@@ -48,6 +48,12 @@ void glue(op_load_gpr_T2_gpr, REG) (void
     T2 = env->gpr[REG];
     RETURN();
 }
+
+void glue(op_store_T2_gpr_gpr, REG) (void)
+{
+    env->gpr[REG] = T2;
+    RETURN();
+}
 #endif
 
 #if defined (TN)

Re: [Qemu-devel] [PATCH] Minor mips-related patchlet

[Paul Brook]

> Index: target-mips/op_mem.c
>...
> +extern void dump_sc (void);

Having function prototypes in .c files is wrong. I added it to exec.h instead.

> +void glue(op_store_T2_gpr_gpr, REG) (void)
> +{
> +    env->gpr[REG] = T2;
> +    RETURN();
> +}

I don't think there's any point adding this unless it's actually used. The ARM 
target doesn't have this op either.

Paul

Re: [Qemu-devel] [PATCH] Minor mips-related patchlet

[Thiemo Seufer]

On Sat, Mar 11, 2006 at 03:01:05PM +0000, Paul Brook wrote:
> > Index: target-mips/op_mem.c
> >...
> > +extern void dump_sc (void);
> 
> Having function prototypes in .c files is wrong. I added it to exec.h instead.
> 
> > +void glue(op_store_T2_gpr_gpr, REG) (void)
> > +{
> > +    env->gpr[REG] = T2;
> > +    RETURN();
> > +}
> 
> I don't think there's any point adding this unless it's actually used. The ARM 
> target doesn't have this op either.

Should it then be removed for other targets where it presumably isn't
used as well?


Thiemo

Re: [Qemu-devel] [PATCH] Minor mips-related patchlet

[Paul Brook]

> > > +void glue(op_store_T2_gpr_gpr, REG) (void)
> > > +{
> > > +    env->gpr[REG] = T2;
> > > +    RETURN();
> > > +}
> >
> > I don't think there's any point adding this unless it's actually used.
> > The ARM target doesn't have this op either.
>
> Should it then be removed for other targets where it presumably isn't
> used as well?

A quick check indicates sparc and i386 use this instruction, mips and arm 
don't have it, and ppc could probably remove it.

Paul