From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, a_mulyadi@softhome.net
Cc: Andre Pech <andre.pech@gmail.com>
Subject: Re: [Qemu-devel] new entry in Qemu forum-- Andre Pech's fix on gdbstub
Date: Mon, 20 Feb 2006 15:03:43 +0000 [thread overview]
Message-ID: <200602201503.44076.paul@codesourcery.com> (raw)
In-Reply-To: <200602201158.22317.a_mulyadi@softhome.net>
On Monday 20 February 2006 04:58, Mulyadi Santosa wrote:
> Hi...
>
> On Sunday 19 February 2006 22:39, Paul Brook wrote:
> > This patch is not sufficient.
> >
> > There seems to be some inconsistency whether cpu_get_phys_page_debug
> > returns the physical address or the base address of the page.
>
> Hm, I am not so sure either. Anyway, using cscope to find out which
> functions that calls cpu_phys_page_debug, seems like it is only called
> during breakpoint setup. So, what ever we do inside
> cpu_get_phys_page_debug doesn't seem affecting other places.
Ideally we'd fix the implementations of cpu_get_phys_page_debug so they are
consistent. IIRC i386-softmmu and ppc-softmmu usually return the page base
address, whereas everything else returns the actual address.
Typically the softmmu implementations use the same pagetable walking code as
the normal tlb fault handling.
The quick and nasty solution is to make breakpoint_invalidate round the
address to a page boundary before calling cpu_get_phys_page_debug, like
cpu_memory_rw_debug does.
Paul
prev parent reply other threads:[~2006-02-20 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 5:06 [Qemu-devel] new entry in Qemu forum-- Andre Pech's fix on gdbstub Mulyadi Santosa
2006-02-19 15:39 ` Paul Brook
2006-02-20 4:58 ` Mulyadi Santosa
2006-02-20 15:03 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602201503.44076.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=a_mulyadi@softhome.net \
--cc=andre.pech@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).