From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FI5aj-0004lr-Lf
	for qemu-devel@nongnu.org; Sat, 11 Mar 2006 10:01:13 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FI5ah-0004kd-Nd
	for qemu-devel@nongnu.org; Sat, 11 Mar 2006 10:01:13 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FI5ah-0004kN-C5
	for qemu-devel@nongnu.org; Sat, 11 Mar 2006 10:01:11 -0500
Received: from [65.74.133.6] (helo=mail.codesourcery.com)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FI5eE-0001KG-Ff
	for qemu-devel@nongnu.org; Sat, 11 Mar 2006 10:04:50 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Minor mips-related patchlet
Date: Sat, 11 Mar 2006 15:01:05 +0000
References: <20060215124530.GC29709@networkno.de>
In-Reply-To: <20060215124530.GC29709@networkno.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200603111501.06862.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> Index: target-mips/op_mem.c
>...
> +extern void dump_sc (void);

Having function prototypes in .c files is wrong. I added it to exec.h instead.

> +void glue(op_store_T2_gpr_gpr, REG) (void)
> +{
> +    env->gpr[REG] = T2;
> +    RETURN();
> +}

I don't think there's any point adding this unless it's actually used. The ARM 
target doesn't have this op either.

Paul