From: Thiemo Seufer <ths@networkno.de>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Minor mips-related patchlet
Date: Mon, 13 Mar 2006 14:41:15 +0000 [thread overview]
Message-ID: <20060313144115.GA10773@networkno.de> (raw)
In-Reply-To: <200603111501.06862.paul@codesourcery.com>
On Sat, Mar 11, 2006 at 03:01:05PM +0000, Paul Brook wrote:
> > Index: target-mips/op_mem.c
> >...
> > +extern void dump_sc (void);
>
> Having function prototypes in .c files is wrong. I added it to exec.h instead.
>
> > +void glue(op_store_T2_gpr_gpr, REG) (void)
> > +{
> > + env->gpr[REG] = T2;
> > + RETURN();
> > +}
>
> I don't think there's any point adding this unless it's actually used. The ARM
> target doesn't have this op either.
Should it then be removed for other targets where it presumably isn't
used as well?
Thiemo
next prev parent reply other threads:[~2006-03-13 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-15 12:45 [Qemu-devel] [PATCH] Minor mips-related patchlet Thiemo Seufer
2006-03-11 15:01 ` Paul Brook
2006-03-13 14:41 ` Thiemo Seufer [this message]
2006-03-13 14:48 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060313144115.GA10773@networkno.de \
--to=ths@networkno.de \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).