qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] SPARC target : Fix carry flag update in addxcc and subxcc ops
Date: Sun, 9 Apr 2006 21:38:48 +0100	[thread overview]
Message-ID: <200604092138.51170.paul@codesourcery.com> (raw)
In-Reply-To: <200604081546.48408.even.rouault@mines-paris.org>

On Saturday 08 April 2006 14:46, Even Rouault wrote:
> I send a patch that should fix a bug in the update of carry flag for addxcc
> and subxcc instructions when the carry flag is set before the evaluation of
> the instruction.
> (the fix is identical to what is done in the similar instruction
> op_adcl_T0_T1_cc for arm target)

    if ((T0 & 0xffffffff) < (src1 & 0xffffffff))
        env->psr |= PSR_CARRY;

Doesn't this condition in addx and the corresponding line in subx need similar 
treatment?

Paul

  reply	other threads:[~2006-04-09 20:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-08 13:46 [Qemu-devel] [PATCH] SPARC target : Fix carry flag update in addxcc and subxcc ops Even Rouault
2006-04-09 20:38 ` Paul Brook [this message]
2006-04-10 18:04   ` [Qemu-devel] [PATCH] SPARC target : Fix carry flag update inaddxcc and subxc Blue Swirl
2006-04-10 18:13     ` Paul Brook
2006-04-10 18:46     ` Laurent Desnogues
2006-04-10 20:18       ` Even Rouault
2006-04-10 17:57 ` [Qemu-devel] [PATCH] SPARC target : Fix carry flag update in addxccand subxc Blue Swirl
  -- strict thread matches above, loose matches on Subject: below --
2006-04-07 22:17 [Qemu-devel] [PATCH] SPARC target : Fix carry flag update in addxcc and subxcc ops Even Rouault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200604092138.51170.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).