From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FSggU-0008DJ-68 for qemu-devel@nongnu.org; Sun, 09 Apr 2006 16:38:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FSggS-0008D7-Hi for qemu-devel@nongnu.org; Sun, 09 Apr 2006 16:38:57 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FSggS-0008D4-CI for qemu-devel@nongnu.org; Sun, 09 Apr 2006 16:38:56 -0400 Received: from [65.74.133.6] (helo=mail.codesourcery.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FSgkw-0004VY-Cf for qemu-devel@nongnu.org; Sun, 09 Apr 2006 16:43:34 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] SPARC target : Fix carry flag update in addxcc and subxcc ops Date: Sun, 9 Apr 2006 21:38:48 +0100 References: <200604081546.48408.even.rouault@mines-paris.org> In-Reply-To: <200604081546.48408.even.rouault@mines-paris.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200604092138.51170.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Saturday 08 April 2006 14:46, Even Rouault wrote: > I send a patch that should fix a bug in the update of carry flag for addxcc > and subxcc instructions when the carry flag is set before the evaluation of > the instruction. > (the fix is identical to what is done in the similar instruction > op_adcl_T0_T1_cc for arm target) if ((T0 & 0xffffffff) < (src1 & 0xffffffff)) env->psr |= PSR_CARRY; Doesn't this condition in addx and the corresponding line in subx need similar treatment? Paul