From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FSzZa-0001lH-MQ for qemu-devel@nongnu.org; Mon, 10 Apr 2006 12:49:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FSzZY-0001io-8R for qemu-devel@nongnu.org; Mon, 10 Apr 2006 12:49:05 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FSzZY-0001iW-18 for qemu-devel@nongnu.org; Mon, 10 Apr 2006 12:49:04 -0400 Received: from [65.74.133.6] (helo=mail.codesourcery.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FSzeD-0002FQ-Mb for qemu-devel@nongnu.org; Mon, 10 Apr 2006 12:53:53 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Updated BGR vs. RGB vga patch... Date: Mon, 10 Apr 2006 17:49:00 +0100 References: <443A86FC.9010302@win4lin.com> <200604101735.39032.paul@codesourcery.com> <443A8B88.5090804@win4lin.com> In-Reply-To: <443A8B88.5090804@win4lin.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200604101749.00725.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Monday 10 April 2006 17:44, Leonardo E. Reiter wrote: > Actually it should probably be made conditionally compiled for now, > until the VGA architecture changes to something more efficient. Would > you agree with that? That way, people who know they will need the hack > can enable it at configure/compile time, and the rest will not be affected. > > How does that sound? I'd be happy to post an updated patch that does that. Making it a configure option sounds a stunningly bad idea. If you're going down that route you may as well make all the output format selection a compile-time option. Paul