[Qemu-devel] [PATCH] use stdio.h

[Qemu-devel] [PATCH] use stdio.h

[Marius Groeger]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 349 bytes --]

Hi,

Changelog:

Make dyngen-exec.h include <stdio.h> which is more portable than the 
local definitions.

Regards,
Marius

-- 
Marius Groeger <mgroeger@sysgo.com>
SYSGO AG                      Embedded and Real-Time Software
Voice: +49 6136 9948 0                  FAX: +49 6136 9948 10
www.sysgo.com | www.elinos.com | www.osek.de | www.pikeos.com

[-- Attachment #2: Type: TEXT/PLAIN, Size: 577 bytes --]

Index: dyngen-exec.h
===================================================================
RCS file: /sources/qemu/qemu/dyngen-exec.h,v
retrieving revision 1.26
diff -u -r1.26 dyngen-exec.h
--- dyngen-exec.h	24 Jul 2005 15:11:38 -0000	1.26
+++ dyngen-exec.h	24 Apr 2006 14:38:28 -0000
@@ -57,9 +57,7 @@
 #define UINT32_MAX		(4294967295U)
 #define UINT64_MAX		((uint64_t)(18446744073709551615))
 
-typedef struct FILE FILE;
-extern int fprintf(FILE *, const char *, ...);
-extern int printf(const char *, ...);
+#include <stdio.h>
 #undef NULL
 #define NULL 0
 

Re: [Qemu-devel] [PATCH] use stdio.h

[Paul Brook]

On Monday 24 April 2006 15:40, Marius Groeger wrote:
> Hi,
>
> Changelog:
>
> Make dyngen-exec.h include <stdio.h> which is more portable than the
> local definitions.

I believe dyngen-exec.h deliberately doesn't include stdio.h because it 
conflicts with the local register variables on some hosts.

Paul

Re: [Qemu-devel] [PATCH] use stdio.h

[Marius Groeger]

On Mon, 24 Apr 2006, Paul Brook wrote:

> On Monday 24 April 2006 15:40, Marius Groeger wrote:
>> Hi,
>>
>> Changelog:
>>
>> Make dyngen-exec.h include <stdio.h> which is more portable than the
>> local definitions.
>
> I believe dyngen-exec.h deliberately doesn't include stdio.h because it
> conflicts with the local register variables on some hosts.

Ah, I thought there's got to be an explanation... Should be added though to
dyngen-exec.h to avoid future patches from wise-guys like myself :-)

Thanks,
Marius

-- 
Marius Groeger <mgroeger@sysgo.com>
SYSGO AG                      Embedded and Real-Time Software
Voice: +49 6136 9948 0                  FAX: +49 6136 9948 10
www.sysgo.com | www.elinos.com | www.osek.de | www.pikeos.com

Re: [Qemu-devel] [PATCH] use stdio.h

[Paul Brook]

> >> Make dyngen-exec.h include <stdio.h> which is more portable than the
> >> local definitions.
> >
> > I believe dyngen-exec.h deliberately doesn't include stdio.h because it
> > conflicts with the local register variables on some hosts.
>
> Ah, I thought there's got to be an explanation... Should be added though to
> dyngen-exec.h to avoid future patches from wise-guys like myself :-)

From the top of that file:

/* NOTE: standard headers should be used with special care at this
   point because host CPU registers are used as global variables. Some
   host headers do not allow that. */

Paul