[Qemu-devel] gnu-c99-math.h file

[Qemu-devel] gnu-c99-math.h file

[Chris Bagwell]

I just upgraded to current CVS to get all the changes submitted today.  
The solaris port commits seems to have added a #include "gnu-c99-math.h" 
file to fpu/softfloat-native.h.

This file doesn't exist on my Fedora Core 5 system with gcc32 installed 
for compatibility.  The mailing archive mentions something about this 
missing file being a custom file for the solaris port. Should that file 
only be referenced under solaris?

Qemu appears to compile fine on linux if I just comment that line out.

Chris

Re: [Qemu-devel] gnu-c99-math.h file

[Troy Benjegerdes]

On Tue, Apr 25, 2006 at 09:04:33PM -0500, Chris Bagwell wrote:
> I just upgraded to current CVS to get all the changes submitted today.  
> The solaris port commits seems to have added a #include "gnu-c99-math.h" 
> file to fpu/softfloat-native.h.
> 
> This file doesn't exist on my Fedora Core 5 system with gcc32 installed 
> for compatibility.  The mailing archive mentions something about this 
> missing file being a custom file for the solaris port. Should that file 
> only be referenced under solaris?
> 
> Qemu appears to compile fine on linux if I just comment that line out.

The same issue occurs on Debian as well.

Re: [Qemu-devel] gnu-c99-math.h file

[Ben Taylor]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]


---- Chris Bagwell <chris@cnpbagwell.com> wrote: 
> I just upgraded to current CVS to get all the changes submitted today.  
> The solaris port commits seems to have added a #include "gnu-c99-math.h" 
> file to fpu/softfloat-native.h.

Apologies.  That should have been isolated with a 

#ifdef __sun__
#include "gnu-c99-math.h"
#endif

> 
> This file doesn't exist on my Fedora Core 5 system with gcc32 installed 
> for compatibility.  The mailing archive mentions something about this 
> missing file being a custom file for the solaris port. Should that file 
> only be referenced under solaris?

correct.  I rechecked the patch  I sent to Fabrice and the gnu-c99-math.h 
file is there.  

> Qemu appears to compile fine on linux if I just comment that line out.
> 
> Chris

The following patch and file will correct the issue for solaris and non-solaris
system alike.

Fabrice - can we get this added to CVS?

Regards,

Ben

[-- Attachment #2: fpu-softfloat-patch.diff --]
[-- Type: application/octet-stream, Size: 104 bytes --]

5a6
> #if !defined(_PRESOLARIS10)
7a9,12
> #endif
> #ifdef __sun__
> #include "gnu-c99-math.h"
> #endif

[-- Attachment #3: gnu-c99-math.h --]
[-- Type: application/octet-stream, Size: 651 bytes --]

#if defined(__sun__) && defined(__GNUC__)

/*
 * C99 7.12.3 classification macros
 * and
 * C99 7.12.14 comparison macros
 *
 * ... do not work on Solaris 10 using GNU CC 3.4.x.
 * Try to workaround the missing / broken C99 math macros.
 */
#include <ieeefp.h>

#define isnormal(x)             (fpclass(x) >= FP_NZERO)

#define isgreater(x, y)         ((!unordered(x, y)) && ((x) > (y)))
#define isgreaterequal(x, y)    ((!unordered(x, y)) && ((x) >= (y)))
#define isless(x, y)            ((!unordered(x, y)) && ((x) < (y)))
#define islessequal(x, y)       ((!unordered(x, y)) && ((x) <= (y)))

#define isunordered(x,y)        unordered(x, y)

#endif

Re: [Qemu-devel] gnu-c99-math.h file

[Sylvain Petreolle]

--- Ben Taylor <sol10x86@cox.net> a écrit :
> 
> Apologies.  That should have been isolated with a 
> 
> #ifdef __sun__
> #include "gnu-c99-math.h"
> #endif
> 
> correct.  I rechecked the patch  I sent to Fabrice and the gnu-c99-math.h 
> file is there.  
please make sure if you use underscores or hyphens.
softfloat-native.h includes gnu-c99-math.h,
but the file attached to this mail was gnu_c99_math.h


Kind regards,
Sylvain Petreolle (aka Usurp)
--- --- --- --- --- --- --- --- --- --- --- --- ---
Listen to free Music: http://www.jamendo.com
Windows is proprietary, use free ReactOS instead : http://www.reactos.org

Re: [Qemu-devel] gnu-c99-math.h file

[Ben Taylor]

---- Sylvain Petreolle <spetreolle@yahoo.fr> wrote: 
> 
> --- Ben Taylor <sol10x86@cox.net> a écrit :
> > 
> > Apologies.  That should have been isolated with a 
> > 
> > #ifdef __sun__
> > #include "gnu-c99-math.h"
> > #endif
> > 
> > correct.  I rechecked the patch  I sent to Fabrice and the gnu-c99-math.h 
> > file is there.  
> please make sure if you use underscores or hyphens.
> softfloat-native.h includes gnu-c99-math.h,
> but the file attached to this mail was gnu_c99_math.h

I have no explaination.  It has hypens on my source system, and on my 
M$ laptop.  The only possible way the name changed was that the new 
webmail interface provided by my cable company  modified the filename 
when I attached the diff and and gnu-c99-math.h file. 
 
But a good catch, and hopefully everyone will know to change the 
file name. 
 
Regards, 
 
Ben