From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fctzr-0004e2-RC for qemu-devel@nongnu.org; Sun, 07 May 2006 20:53:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fctzp-0004dB-Eb for qemu-devel@nongnu.org; Sun, 07 May 2006 20:53:11 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fctzp-0004d8-BF for qemu-devel@nongnu.org; Sun, 07 May 2006 20:53:09 -0400 Received: from [65.74.133.6] (helo=mail.codesourcery.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Fcu0X-0008Ew-Ud for qemu-devel@nongnu.org; Sun, 07 May 2006 20:53:54 -0400 From: Paul Brook Subject: Re: [Qemu-devel] -cc checking wrong Date: Mon, 8 May 2006 01:53:03 +0100 References: <87aca2qjj9.fsf@Janik.cz> <87d5eppicn.fsf@Janik.cz> <20060508001855.GA15033@jbrown.mylinuxbox.org> In-Reply-To: <20060508001855.GA15033@jbrown.mylinuxbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200605080153.03721.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Monday 08 May 2006 01:18, Jim C. Brown wrote: > On Mon, May 08, 2006 at 12:46:24AM +0200, Pavel Jan?k wrote: > > configure contains: > > > > if [ ! -x "`which $cc`" ] ; then > > echo "Compiler $cc could not be found" > > exit > > fi > > > > You should check if the command compiles, not if it exists and is > > executable. > > Patch attached. Simply tries to compile a dummy program. You really should test your patches. The patch you attached generates an error if the compiler works. Paul