From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fd82y-0005uJ-8P for qemu-devel@nongnu.org; Mon, 08 May 2006 11:53:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fd82t-0005sL-Mi for qemu-devel@nongnu.org; Mon, 08 May 2006 11:53:18 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fd82t-0005sI-I1 for qemu-devel@nongnu.org; Mon, 08 May 2006 11:53:15 -0400 Received: from [128.8.10.163] (helo=po1.wam.umd.edu) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fd83l-00060Z-2R for qemu-devel@nongnu.org; Mon, 08 May 2006 11:54:09 -0400 Date: Mon, 8 May 2006 11:53:13 -0400 From: "Jim C. Brown" Subject: Re: [Qemu-devel] Patch submission policy? (was Re: [PATCH] SAMBA multi-share support Message-ID: <20060508155313.GA15522@jbrown.mylinuxbox.org> References: <94daf69cfb5ca0d73230f9588487fe3f@triplecatproductions.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94daf69cfb5ca0d73230f9588487fe3f@triplecatproductions.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stealth Dave Cc: QEMU Sorry for not replies to this earlier. It got lost in my spam folder somehow. On Mon, May 01, 2006 at 12:29:15PM -0700, Stealth Dave wrote: > Is there a patch submission policy for QEMU? I see a lot of patches > posted to this list. Some get accepted, some get rejected with > comments, and others seem to be ignored. Patches are suppose to be sent to this list. If its a big change, you are suppose to split it up into smaller patches and send those (so they can be applied one by one). Beyond that I don't know of any rules. When patches are ignores, that usually means that it got lost in the mail. Thats when you have to get a little bit pushy. > Back in February, I submitted > a patch which expands the SAMBA capabilities of QEMU to allow multiple > folders to be shared, and was backwards compatible with the old syntax. > I resubmitted the patch via private email to the lead devs (Fabrice > and Paul, the latter I presume can be considered a lead dev as he > appears to have CVS commit access), but again got no feedback. > > I'm perfectly willing to accept that my patch isn't good enough for > inclusion, or even that the new functionality is not wanted (although, > I'd be dissappointed). But without any feedback whatsoever, I can't > make improvements and, quite frankly, am feeling a little bit left out > in the cold. Agreed. Feedback about rejected patches is crucial. BTW, You can always come into the IRC channel and ask about it there. > > Regards, > - Dave -- Infinite complexity begets infinite beauty. Infinite precision begets infinite perfection.