From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Fdx3x-0004Tm-NW
	for qemu-devel@nongnu.org; Wed, 10 May 2006 18:21:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Fdx3v-0004Sx-Sl
	for qemu-devel@nongnu.org; Wed, 10 May 2006 18:21:45 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Fdx3v-0004Sn-Ol
	for qemu-devel@nongnu.org; Wed, 10 May 2006 18:21:43 -0400
Received: from [81.103.221.47] (helo=mtaout01-winn.ispmail.ntl.com)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fdx5I-0000xb-CZ
	for qemu-devel@nongnu.org; Wed, 10 May 2006 18:23:08 -0400
Received: from aamtaout02-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout01-winn.ispmail.ntl.com with ESMTP id
	<20060510222137.UBRG29343.mtaout01-winn.ispmail.ntl.com@aamtaout02-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Wed, 10 May 2006 23:21:37 +0100
Received: from suse10.valgrind.org ([82.21.96.252])
	by aamtaout02-winn.ispmail.ntl.com with ESMTP id
	<20060510222137.RECA24467.aamtaout02-winn.ispmail.ntl.com@suse10.valgrind.org>
	for <qemu-devel@nongnu.org>; Wed, 10 May 2006 23:21:37 +0100
From: Julian Seward <jseward@acm.org>
Subject: Re: [Qemu-devel] PATCH: fix bgr color mapping on qemu on Solaris/SPARC
Date: Wed, 10 May 2006 23:21:36 +0100
References: <9893291.1147284983406.JavaMail.root@eastrmwml06.mgt.cox.net>
	<200605102230.06357.paul@codesourcery.com>
In-Reply-To: <200605102230.06357.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200605102321.36352.jseward@acm.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


> autodetect what color format to use. Also putting if inside the inner loop
> of the low-level conversion routines is a bad idea.

While that's per-se true, maybe it's not such a big deal.  The branch is
going to be perfectly predictable since the condition stays the same 
for the entire run, so I'd be surprised if you even lost one host cycle
per iteration overall.  Basically the hardware will fold it out.

J