From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1G1EO5-0004My-SQ
	for qemu-devel@nongnu.org; Thu, 13 Jul 2006 23:30:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1G1ENy-0004MT-Q6
	for qemu-devel@nongnu.org; Thu, 13 Jul 2006 23:30:45 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1G1ENy-0004MQ-Kr
	for qemu-devel@nongnu.org; Thu, 13 Jul 2006 23:30:38 -0400
Received: from [65.74.133.4] (helo=mail.codesourcery.com)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1G1EPq-0008J6-0s
	for qemu-devel@nongnu.org; Thu, 13 Jul 2006 23:32:35 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] fix for qemu-* looping forever on symlinks (patch
	attached)
Date: Fri, 14 Jul 2006 04:30:00 +0100
References: <8e2a98be0607131931i614eae05n8b95715e13f46efd@mail.gmail.com>
In-Reply-To: <8e2a98be0607131931i614eae05n8b95715e13f46efd@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200607140430.01678.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Michael Gilbert <michael.s.gilbert@gmail.com>

On Friday 14 July 2006 03:31, Michael Gilbert wrote:
> please review the attached patch (to linux-user/path.c), which i
> believe fixes the problem of qemu looping forever on symlinks when
> using -L.  it is undesirable (i believe) for the -L option to search
> all subdirectories.  this is in reference to debian bug #297572 
> (bugs.debian.org/297572).

Have you tried running dynamically linked executables with your patch?

The whole point of the -L option is so that it picks up target shared 
libraries, eg. in lib and usr/lib. By my reading your patch makes the -L 
option do absolutely nothing, which can't be right.

The proper fix is to do the lookups when a file is accesses (possibly with 
caching) not pre-scan the whole tree.

Paul