From: Jung-uk Kim <jkim@FreeBSD.org>
To: freebsd-emulation@FreeBSD.org
Cc: freebsd-usb@FreeBSD.org, Juergen Lock <qemu-l@jelal.kn-bremen.de>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: FreeBSD qemu 0.8.2 update - please test! (and usb cardreader SET_ADDR_FAILED)
Date: Tue, 25 Jul 2006 23:06:31 -0000 [thread overview]
Message-ID: <200607251906.10687.jkim@FreeBSD.org> (raw)
In-Reply-To: <20060725174719.GA16116@saturn.kn-bremen.de>
On Tuesday 25 July 2006 01:47 pm, Juergen Lock wrote:
> @@ -47,21 +43,20 @@
> void set_float_rounding_mode(int val STATUS_PARAM)
> {
> STATUS(float_rounding_mode) = val;
> --#if defined(_BSD) && !defined(__APPLE__)
> -+#if defined(_BSD) && !defined(__APPLE__) && \
> -+ (defined(__FreeBSD__) && __FreeBSD_version < 500000)
> +-#if defined(_BSD) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && HOST_SOLARIS < 10)
> ++#if (defined(_BSD) && (defined(__FreeBSD__) && __FreeBSD_version < 500000)) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && HOST_SOLARIS < 10)
> fpsetround(val);
> #elif defined(__arm__)
> /* nothing to do */
FYI, a parenthesis is misplaced (Note: I just rearranged
the order to be more clearer):
+-#if defined(_BSD) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && HOST_SOLARIS < 10)
++#if (defined(_BSD) && !defined(__APPLE__) && (defined(__FreeBSD__) && __FreeBSD_version < 500000)) || \
++ (defined(HOST_SOLARIS) && HOST_SOLARIS < 10)
Actually it is an upstream bug, though.
Thanks,
Jung-uk Kim
next prev parent reply other threads:[~2006-07-25 23:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-23 22:40 [Qemu-devel] qemu 0.8.2 update - please test! (and usb cardreader SET_ADDR_FAILED) Juergen Lock
2006-07-23 22:51 ` [Qemu-devel] FreeBSD! :) (was: Re: qemu 0.8.2 update - please test! (and usb cardreader SET_ADDR_FAILED)) Juergen Lock
2006-07-25 17:47 ` [Qemu-devel] Re: FreeBSD qemu 0.8.2 update - please test! (and usb cardreader SET_ADDR_FAILED) Juergen Lock
2006-07-25 23:06 ` Jung-uk Kim [this message]
2006-07-28 17:33 ` Juergen Lock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607251906.10687.jkim@FreeBSD.org \
--to=jkim@freebsd.org \
--cc=freebsd-emulation@FreeBSD.org \
--cc=freebsd-usb@FreeBSD.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-l@jelal.kn-bremen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).