qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC][PATCH] make sure disk writes actually hit disk
Date: Sat, 29 Jul 2006 17:04:44 +0100	[thread overview]
Message-ID: <200607291704.45217.paul@codesourcery.com> (raw)
In-Reply-To: <44CB77DF.9030700@redhat.com>

On Saturday 29 July 2006 15:59, Rik van Riel wrote:
> Fabrice Bellard wrote:
> > Hi,
> >
> > Using O_SYNC for disk image access is not acceptable: QEMU relies on the
> > host OS to ensure that the data is written correctly.
>
> This means that write ordering is not preserved, and on a power
> failure any data written by qemu (or Xen fully virt) guests may
> not be preserved.

I might be willing to accept this (or similar) patch if you made it 
conditional on the guest having disabled write caching. I agree with Fabrice 
that the performance impact it too severe to consider turning it on by 
default. 

The same problems occurs with many hardware RAID controllers, and even many 
harddrives: fsync() only guarantees that the data has been passed to the 
controller (in this case the host OS). If you need absolute reliability you 
either need more flusing in your guest OS, disable the write cache, or 
battery backup to make sure the IDE hardware (ie. host OS) doesn't die 
unexpectedly.

Paul

  reply	other threads:[~2006-07-29 16:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-28 19:54 [Qemu-devel] [RFC][PATCH] make sure disk writes actually hit disk Rik van Riel
2006-07-28 19:58 ` [Qemu-devel] " Rik van Riel
2006-07-28 20:12 ` Anthony Liguori
2006-07-28 20:18   ` Rik van Riel
2006-07-28 20:30     ` Paul Brook
2006-07-28 20:43       ` Rik van Riel
2006-07-28 21:01         ` Paul Brook
2006-07-31  7:08     ` Jens Axboe
2006-07-29  9:57 ` [Qemu-devel] " Fabrice Bellard
2006-07-29 14:59   ` Rik van Riel
2006-07-29 16:04     ` Paul Brook [this message]
2006-07-29 16:22       ` Rik van Riel
2006-07-29 16:31         ` Paul Brook
2006-07-31  7:08           ` Jens Axboe
2006-07-29 17:33     ` Bill C. Riemers
2006-07-30 21:47       ` Jamie Lokier
2006-07-30 21:41     ` Jamie Lokier
2006-07-31  9:52       ` andrzej zaborowski
2006-07-31 10:17         ` Jens Axboe
2006-07-31 17:50           ` andrzej zaborowski
2006-07-31  7:08     ` Jens Axboe
2006-07-31  7:56       ` Jonas Maebe
2006-07-31  8:18         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200607291704.45217.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).