From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GJpXV-00045m-Bo for qemu-devel@nongnu.org; Sun, 03 Sep 2006 06:49:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GJpXV-00045K-2F for qemu-devel@nongnu.org; Sun, 03 Sep 2006 06:49:21 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GJpXU-00044w-Oe for qemu-devel@nongnu.org; Sun, 03 Sep 2006 06:49:20 -0400 Received: from [65.74.133.4] (helo=mail.codesourcery.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GJphl-0005W7-OY for qemu-devel@nongnu.org; Sun, 03 Sep 2006 06:59:58 -0400 From: Paul Brook Subject: Re: [Qemu-devel] AIO and savevm Date: Sun, 3 Sep 2006 11:49:15 +0100 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200609031149.16112.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On Sunday 03 September 2006 11:42, Blue Swirl wrote: > >When savevm is issued, you need to halt the guest CPUs, and wait for all > > IO to > >complete. While doing this you need to allow device AIO completion > > routines to run, which may trigger additional IO. Once all IO has been > > completed you should then be able to safely save state. > > How's this patch? Qemu_aio_poll waits for all AIOs and calls the device > completion routines when each AIO finishes. qemu_aio_poll doesn't wait. It returns immediately if IO has not completed yet. Paul