qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Keil <jk@tools.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] monitor "info" command crashes qemu
Date: Mon, 25 Sep 2006 10:10:18 +0200 (CEST)	[thread overview]
Message-ID: <200609250814.k8P8Em6D002496@imap1.tools.intra> (raw)

The monitor's "info" command crashes qemu on a Solaris host.

Apparently a NULL pointer is passed as argument for a "%s" printf format
string.

The "info capture" command has a missing "params" string (help string is used
as params structure member and help structure member is NULL).

And "info snapshots" has copied&pasted the buggy structure initializer.


Fix:



Index: monitor.c
===================================================================
RCS file: /cvsroot/qemu/qemu/monitor.c,v
retrieving revision 1.56
diff -u -B -r1.56 monitor.c
--- monitor.c   5 Aug 2006 21:31:00 -0000       1.56
+++ monitor.c   25 Sep 2006 08:05:58 -0000
@@ -1230,9 +1230,9 @@
     { "profile", "", do_info_profile,
       "", "show profiling information", },
     { "capture", "", do_info_capture,
-      "show capture information" },
+      "", "show capture information" },
     { "snapshots", "", do_info_snapshots,
-      "show the currently saved VM snapshots" },
+      "", "show the currently saved VM snapshots" },
     { NULL, NULL, },
 };

                 reply	other threads:[~2006-09-25  8:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200609250814.k8P8Em6D002496@imap1.tools.intra \
    --to=jk@tools.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).