From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GRlt6-0008M6-4j
	for qemu-devel@nongnu.org; Mon, 25 Sep 2006 04:32:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GRlt4-0008KN-9T
	for qemu-devel@nongnu.org; Mon, 25 Sep 2006 04:32:27 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GRlt4-0008KJ-3q
	for qemu-devel@nongnu.org; Mon, 25 Sep 2006 04:32:26 -0400
Received: from [192.76.135.70] (helo=kurt.TooLs.DE)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1GRlxQ-0000y3-I6
	for qemu-devel@nongnu.org; Mon, 25 Sep 2006 04:36:56 -0400
Received: from imap1.tools.intra (imap1.tools.intra [172.20.0.17])
	by kurt.TooLs.DE (Postfix) with ESMTP id EF04BC641
	for <qemu-devel@nongnu.org>; Mon, 25 Sep 2006 10:10:18 +0200 (MEST)
Received: from tiger2.tools.intra (tiger2.tools.intra [172.20.0.11])
	by imap1.tools.intra (8.13.1+Sun/8.13.1) with SMTP id k8P8Em6D002496
	for <qemu-devel@nongnu.org>; Mon, 25 Sep 2006 10:14:49 +0200 (MEST)
Message-Id: <200609250814.k8P8Em6D002496@imap1.tools.intra>
Date: Mon, 25 Sep 2006 10:10:18 +0200 (CEST)
From: Juergen Keil <jk@tools.de>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
Content-MD5: hwvkw/+XLs+RNyd5Of0/2Q==
Subject: [Qemu-devel] [PATCH] monitor "info" command crashes qemu
Reply-To: Juergen Keil <jk@tools.de>, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

The monitor's "info" command crashes qemu on a Solaris host.

Apparently a NULL pointer is passed as argument for a "%s" printf format
string.

The "info capture" command has a missing "params" string (help string is used
as params structure member and help structure member is NULL).

And "info snapshots" has copied&pasted the buggy structure initializer.


Fix:



Index: monitor.c
===================================================================
RCS file: /cvsroot/qemu/qemu/monitor.c,v
retrieving revision 1.56
diff -u -B -r1.56 monitor.c
--- monitor.c   5 Aug 2006 21:31:00 -0000       1.56
+++ monitor.c   25 Sep 2006 08:05:58 -0000
@@ -1230,9 +1230,9 @@
     { "profile", "", do_info_profile,
       "", "show profiling information", },
     { "capture", "", do_info_capture,
-      "show capture information" },
+      "", "show capture information" },
     { "snapshots", "", do_info_snapshots,
-      "show the currently saved VM snapshots" },
+      "", "show the currently saved VM snapshots" },
     { NULL, NULL, },
 };