qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] why do qem/arm not clear CPU_INTERRUPT_HARD bit of env->interrupt_request automatically?
Date: Sun, 8 Oct 2006 03:23:21 +0100	[thread overview]
Message-ID: <200610080323.21706.paul@codesourcery.com> (raw)
In-Reply-To: <84e41160610071115t75b4ec55vbe656630d5ab9373@mail.gmail.com>

On Saturday 07 October 2006 19:15, Donald Liew wrote:
> i'm reading qemu-system-arm code and trying to add some more
> evaluation boards support for it. in the 0.8.2 source code i found
> something i can't understand, when handling interrupts all other
> targets clears this bit after calling do_interrupt, however the arm
> target doesn't do this, why? won't this cause problems like redundant
> interrupts? any special consideration about this?

I this this is the correct behavior. The nIRQ line is level triggered. 
spurious interrupts are avoided because do_interrupt sets the CPSR_I flag.

During normal operation theguest OS will clear the IRQ condition (by masking 
the interrupt on the PIC or device) before clearing the CPSE_I flag, so it 
doesn't matter what we do.

Consider the case where the guest OS were to clear CPSR_F without touching the 
IRQ line. In this case we would expect annother IRQ exception to be taken 
immediately. If (as you suggest above) we cleared CPU_INTERRUPT_HARD in 
cpu_exec then the IRQ would not be taken until something re-raised the IRQ 
line.

Paul

  reply	other threads:[~2006-10-08  2:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-07 18:15 [Qemu-devel] why do qem/arm not clear CPU_INTERRUPT_HARD bit of env->interrupt_request automatically? Donald Liew
2006-10-08  2:23 ` Paul Brook [this message]
2006-10-08  7:40   ` Donald Liew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200610080323.21706.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).