[Qemu-devel] qemu/target-mips helper.c translate.c

[Qemu-devel] qemu/target-mips helper.c translate.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	06/12/07 16:22:15

Modified files:
	target-mips    : helper.c translate.c 

Log message:
	Fix reset handling, CP0 isn't enabled by default (a fact which doesn't
	matter when running in kernel space).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/target-mips/helper.c?cvsroot=qemu&r1=1.17&r2=1.18
http://cvs.savannah.gnu.org/viewcvs/qemu/target-mips/translate.c?cvsroot=qemu&r1=1.24&r2=1.25

Re: [Qemu-devel] qemu/target-mips helper.c translate.c (compiler error)

[Stefan Weil]

Hi,

the latest changes of QEMU CVS break compilation for MIPS systems
without a FPU. Such systems are in wide use (DSL routers like
Sinus 154 and Fritz!Box), and several developers already use QEMU
for emulation of these systems.

I'm sorry that I cannot provide a patch which fixes the compiler
errors. The patch given below can be used to get my test configuration.

Regards
Stefan Weil


Patch for compilation test of MIPS system without FPU

RCS file: /sources/qemu/qemu/target-mips/mips-defs.h,v
retrieving revision 1.5
diff -u -b -B -r1.5 mips-defs.h
--- target-mips/mips-defs.h     6 Dec 2006 20:17:30 -0000       1.5
+++ target-mips/mips-defs.h     7 Dec 2006 18:23:09 -0000
@@ -25,6 +25,7 @@
 #define MIPS_TLB_MAX 128
 /* basic FPU register support */
 #define MIPS_USES_FPU 1
+#undef MIPS_USES_FPU
 /* Define a implementation number of 1.
  * Define a major version 1, minor version 0.
  */

Re: [Qemu-devel] qemu/target-mips helper.c translate.c (compiler error)

[Paul Brook]

On Thursday 07 December 2006 18:44, Stefan Weil wrote:
> Hi,
>
> the latest changes of QEMU CVS break compilation for MIPS systems
> without a FPU. Such systems are in wide use (DSL routers like
> Sinus 154 and Fritz!Box), and several developers already use QEMU
> for emulation of these systems.

If you made the effort to submit these ports, instead of maintaining them out 
of tree, they'd be less likely to get broken.

Paul

Re: [Qemu-devel] qemu/target-mips helper.c translate.c (compiler error)

[Thiemo Seufer]

Paul Brook wrote:
> On Thursday 07 December 2006 18:44, Stefan Weil wrote:
> > Hi,
> >
> > the latest changes of QEMU CVS break compilation for MIPS systems
> > without a FPU. Such systems are in wide use (DSL routers like
> > Sinus 154 and Fritz!Box), and several developers already use QEMU
> > for emulation of these systems.
> 
> If you made the effort to submit these ports, instead of maintaining them out 
> of tree, they'd be less likely to get broken.

To be fair, getting MIPS patches in used to be tedious. I'm currently
testing a fix for FPU-less operation.


Thiemo

Re: [Qemu-devel] qemu/target-mips helper.c translate.c (compiler error)

[Thiemo Seufer]

Stefan Weil wrote:
> Hi,
> 
> the latest changes of QEMU CVS break compilation for MIPS systems
> without a FPU. Such systems are in wide use (DSL routers like
> Sinus 154 and Fritz!Box), and several developers already use QEMU
> for emulation of these systems.

Fixed, thanks for the report.


Thiemo

Re: [Qemu-devel] qemu/target-mips helper.c translate.c (compiler error)

[Stefan Weil]

Paul, did you get my last mailing on this subject?
(see http://lists.gnu.org/archive/html/qemu-devel/2006-05/msg00280.html)

I'd be very glad to maintain my code in the tree, but Thiemo is right.
Today, it takes sometimes very long until a patch gets integrated.

Maybe a switch to another configuration management system might allow
more people to contribute. My personal experiences with switching from
CVS to Subversion are very positive, and I offer my help in doing it.

Thank you, Thiemo, for the quick reaction on my report. CVS is working
again.

Stefan

Paul Brook schrieb:
>
> If you made the effort to submit these ports, instead of maintaining
> them out
> of tree, they'd be less likely to get broken.
>
> Paul
>

Re: [Qemu-devel] qemu/target-mips helper.c translate.c (compiler error)

[Paul Brook]

On Thursday 07 December 2006 22:22, Stefan Weil wrote:
> Paul, did you get my last mailing on this subject?
> (see http://lists.gnu.org/archive/html/qemu-devel/2006-05/msg00280.html)

My point exactly. Posting a link to a random website isn't sufficient, 
especially when you say "my patches are still not ready for integration".

I think it's fair to say that everyone involved with qemu doesn't even have 
time to do the things they are personally interested in. If you want to get 
things integrated *you* have to put the effort in to get it submitted in a 
form where that can happen.

Paul