* [Qemu-devel] Re: [MIPS] Use conditional traps for BUG_ON on MIPS II and better. [not found] ` <20061203213518.GA22225@linux-mips.org> @ 2006-12-15 16:26 ` Atsushi Nemoto 2006-12-16 17:11 ` Thiemo Seufer 0 siblings, 1 reply; 2+ messages in thread From: Atsushi Nemoto @ 2006-12-15 16:26 UTC (permalink / raw) To: ralf; +Cc: linux-mips, qemu-devel On Sun, 3 Dec 2006 21:35:18 +0000, Ralf Baechle <ralf@linux-mips.org> wrote: > > It seems this commit break QEMU kernel ... or QEMU can not interpret > > the TNE instruction correctly? > > Thiemo says that's indeed a possibility. Probably that feature has not > been well tested in qemu. I found the bug. "Trap If XXX" instructions are translated as it was "Trap If XXX Immediate". Index: target-mips/translate.c =================================================================== RCS file: /sources/qemu/qemu/target-mips/translate.c,v retrieving revision 1.27 diff -u -r1.27 translate.c --- target-mips/translate.c 10 Dec 2006 22:08:10 -0000 1.27 +++ target-mips/translate.c 15 Dec 2006 16:16:07 -0000 @@ -1276,6 +1276,7 @@ GEN_LOAD_REG_TN(T1, rt); cond = 1; } + break; case OPC_TEQI: case OPC_TGEI: case OPC_TGEIU: --- Atsushi Nemoto ^ permalink raw reply [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [MIPS] Use conditional traps for BUG_ON on MIPS II and better. 2006-12-15 16:26 ` [Qemu-devel] Re: [MIPS] Use conditional traps for BUG_ON on MIPS II and better Atsushi Nemoto @ 2006-12-16 17:11 ` Thiemo Seufer 0 siblings, 0 replies; 2+ messages in thread From: Thiemo Seufer @ 2006-12-16 17:11 UTC (permalink / raw) To: Atsushi Nemoto; +Cc: linux-mips, qemu-devel Atsushi Nemoto wrote: > On Sun, 3 Dec 2006 21:35:18 +0000, Ralf Baechle <ralf@linux-mips.org> wrote: > > > It seems this commit break QEMU kernel ... or QEMU can not interpret > > > the TNE instruction correctly? > > > > Thiemo says that's indeed a possibility. Probably that feature has not > > been well tested in qemu. > > I found the bug. "Trap If XXX" instructions are translated as it was > "Trap If XXX Immediate". > > Index: target-mips/translate.c > =================================================================== > RCS file: /sources/qemu/qemu/target-mips/translate.c,v > retrieving revision 1.27 > diff -u -r1.27 translate.c > --- target-mips/translate.c 10 Dec 2006 22:08:10 -0000 1.27 > +++ target-mips/translate.c 15 Dec 2006 16:16:07 -0000 > @@ -1276,6 +1276,7 @@ > GEN_LOAD_REG_TN(T1, rt); > cond = 1; > } > + break; > case OPC_TEQI: > case OPC_TGEI: > case OPC_TGEIU: Thanks, committed. Thiemo ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-16 17:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <S20037651AbWK3BXW/20061130012322Z+10503@ftp.linux-mips.org>
[not found] ` <20061204.015327.36921579.anemo@mba.ocn.ne.jp>
[not found] ` <20061203213518.GA22225@linux-mips.org>
2006-12-15 16:26 ` [Qemu-devel] Re: [MIPS] Use conditional traps for BUG_ON on MIPS II and better Atsushi Nemoto
2006-12-16 17:11 ` Thiemo Seufer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).