From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gxrzt-0007Td-22 for qemu-devel@nongnu.org; Fri, 22 Dec 2006 16:32:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gxrzs-0007Sl-2r for qemu-devel@nongnu.org; Fri, 22 Dec 2006 16:32:08 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gxrzr-0007SZ-PG for qemu-devel@nongnu.org; Fri, 22 Dec 2006 16:32:07 -0500 Received: from [65.74.133.4] (helo=mail.codesourcery.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Gxrzr-0008W8-3c for qemu-devel@nongnu.org; Fri, 22 Dec 2006 16:32:07 -0500 From: Paul Brook Subject: Re: [Qemu-devel] patch for supporting SMB on Solaris host Date: Fri, 22 Dec 2006 21:32:03 +0000 References: <33061851.1166818049407.JavaMail.root@eastrmwml03.mgt.cox.net> <200612222129.36745.paul@codesourcery.com> In-Reply-To: <200612222129.36745.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200612222132.04494.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Friday 22 December 2006 21:29, Paul Brook wrote: > On Friday 22 December 2006 20:07, Ben Taylor wrote: > > Seeing as there is some working going on in the Solaris QEMU port again, > > here's a real short patch to support Samba working on a Solaris Host. > > +#ifdef __sun__ > > + snprintf(smb_cmdline, sizeof(smb_cmdline), "/bin/env LC_ALL=C > > /usr/sfw/sbin/smbd -s %s", > > + smb_conf); > > +#else > > Why does this have anything to do with solaris? Sorry, I was unclear. The /usr/swf bif is obviously a Solaris hack, and I think this is a bad way of implementing this. I don't see why the /bin/env LC_ALL bits have anything to do with Solaris. Paul