qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Fischer <rep.nop@aon.at>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu Makefile configure
Date: Wed, 3 Jan 2007 15:23:40 +0100	[thread overview]
Message-ID: <20070103142339.GE24482@aon.at> (raw)
In-Reply-To: <20070103135950.GB5849@networkno.de>

On Wed, Jan 03, 2007 at 01:59:50PM +0000, Thiemo Seufer wrote:

>All of this works fine for me, but patches of this sort are likely to
>break things, so please test and comment.
>
>
>Thiemo
>

>Index: Makefile.target
>===================================================================
>RCS file: /sources/qemu/qemu/Makefile.target,v
>retrieving revision 1.134
>diff -u -p -r1.134 Makefile.target
>--- Makefile.target	7 Dec 2006 18:15:35 -0000	1.134
>+++ Makefile.target	3 Jan 2007 13:47:50 -0000
>@@ -91,66 +91,66 @@ endif
> endif
> 
> ifeq ($(ARCH),x86_64)
>-OP_CFLAGS=$(CFLAGS) -falign-functions=0
>-LDFLAGS+=-Wl,-T,$(SRC_PATH)/x86_64.ld
>+LDFLAGS+=-Wl,-T,$(SRC_PATH)/$(ARCH).ld
> endif
> 
> ifeq ($(ARCH),ppc)
-> CFLAGS+= -D__powerpc__
+ CPPFLAGS += -D__powerpc__

(doesn't cpp already define that on ppc?)

>Index: configure
>===================================================================
>RCS file: /sources/qemu/qemu/configure,v
>retrieving revision 1.115
>diff -u -p -r1.115 configure
>--- configure	1 Jan 2007 21:31:01 -0000	1.115
>+++ configure	3 Jan 2007 13:47:50 -0000
>@@ -243,6 +244,10 @@ for opt do
>   esac
> done
> 
>+# default flags for all hosts
>+CFLAGS=$CFLAGS "-Wall -O2 -g -fno-strict-aliasing"
>+LDFLAGS=$LDFLAGS "-g"

Does that really work for you?
I'd rather say
LDFLAGS="$LDFLAGS -g"

cheers,

  reply	other threads:[~2007-01-03 14:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-01 21:31 [Qemu-devel] qemu Makefile configure Thiemo Seufer
2007-01-03 13:59 ` Thiemo Seufer
2007-01-03 14:23   ` Bernhard Fischer [this message]
2007-01-03 15:09     ` Thiemo Seufer
2007-01-07 21:58     ` Pierre d'Herbemont
2007-01-03 14:42   ` Thiemo Seufer
2007-01-03 14:55     ` Daniel Jacobowitz
2007-01-03 15:36       ` Thiemo Seufer
2007-01-03 15:43   ` Fabrice Bellard
2007-01-03 16:16     ` Thiemo Seufer
2007-01-03 16:58       ` Bernhard Fischer
2007-01-04 12:26       ` Thiemo Seufer
2007-01-05  1:03         ` Thiemo Seufer
  -- strict thread matches above, loose matches on Subject: below --
2007-12-09  5:10 Thiemo Seufer
2007-09-22 16:49 Paul Brook
2006-04-23 17:57 Paul Brook
2006-04-30 15:04 ` Leonardo E. Reiter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070103142339.GE24482@aon.at \
    --to=rep.nop@aon.at \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).