[Qemu-devel] [PATCH] qemu-dm monitor doesn't support the quit command.

[Qemu-devel] [PATCH] qemu-dm monitor doesn't support the quit command.

[Kasai Takanori]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Hi All,

It is natural that there is quit command in original QEMU. 
However, I don't think that the HVM domain on Xen is necessary.
Because there is a possibility of shutting down GuestOS due to the mistake. 
I think that I should prohibit the quit command of qemu-dm. 

Thanks

--
Takanori Kasai

[-- Attachment #2: qemu-monitor-quit.patch --]
[-- Type: application/octet-stream, Size: 650 bytes --]

# HG changeset patch
# User kasai.takanori@jp.fujitsu.com
# Node ID ef195d27a54ef7d5e256788d5a1a51ee55e2bcf6
# Parent  360eb996fa38319867a74bf581c734a80bf6839d
The quit command of the Qemu-dm monitor is made invalid.

diff -r 360eb996fa38 -r ef195d27a54e tools/ioemu/monitor.c
--- a/tools/ioemu/monitor.c	Wed Dec 13 16:13:26 2006 +0000
+++ b/tools/ioemu/monitor.c	Thu Dec 21 12:08:18 2006 +0900
@@ -309,8 +309,7 @@ static void do_info_history (void)
 
 static void do_quit(void)
 {
-    destroy_hvm_domain();
-    exit(0);
+    term_printf("quit is not supported\n");
 }
 
 static int eject_device(BlockDriverState *bs, int force)

Re: [Qemu-devel] [PATCH] qemu-dm monitor doesn't support the quit command.

[Thiemo Seufer]

Kasai Takanori wrote:
> Hi All,
> 
> It is natural that there is quit command in original QEMU. 
> However, I don't think that the HVM domain on Xen is necessary.
> Because there is a possibility of shutting down GuestOS due to the mistake. 
> I think that I should prohibit the quit command of qemu-dm. 

Better #ifdef out the quit command for HVM then, so people aren't
tempted to use it.

(Whatever HVM is, qemu doesn't know about it for now, so this patch is
currently not suitable for the qemu CVS.)


Thiemo