From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch] add configure check for working alsa
Date: Thu, 4 Jan 2007 19:21:40 +0000 [thread overview]
Message-ID: <200701041921.41677.paul@codesourcery.com> (raw)
In-Reply-To: <20070104150259.GE28746@aon.at>
On Thursday 04 January 2007 15:02, Bernhard Fischer wrote:
> Hi,
>
> This patchlet adds a check to configure that makes sure that we have a
> working alsa setup.
>
> Previously, if --enable-alsa was given but the user forgot to install
> the alsa libs proper, the build failed later on due to eventually
> missing libs. The patch makes sure that the user can spot that alsa
> support was turned off after configuration completed.
This is wrong. If the user requests alsa we should honour that request, or
fail trying. We should never quietly ignore an explicit user decision.
Making configure fail early with an error is acceptable (as it the current
link failure). Ignoring --enable-alsa is not.
Paul
next prev parent reply other threads:[~2007-01-04 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-04 15:02 [Qemu-devel] [patch] add configure check for working alsa Bernhard Fischer
2007-01-04 19:21 ` Paul Brook [this message]
2007-01-04 19:47 ` Bernhard Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701041921.41677.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).