From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H2YGM-0001GN-Kd for qemu-devel@nongnu.org; Thu, 04 Jan 2007 14:28:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H2YGK-0001FZ-W8 for qemu-devel@nongnu.org; Thu, 04 Jan 2007 14:28:30 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H2YGK-0001FS-Pl for qemu-devel@nongnu.org; Thu, 04 Jan 2007 14:28:28 -0500 Received: from [65.74.133.4] (helo=mail.codesourcery.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1H2YGK-0006VE-8z for qemu-devel@nongnu.org; Thu, 04 Jan 2007 14:28:28 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [patch] add configure check for working alsa Date: Thu, 4 Jan 2007 19:21:40 +0000 References: <20070104150259.GE28746@aon.at> In-Reply-To: <20070104150259.GE28746@aon.at> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701041921.41677.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thursday 04 January 2007 15:02, Bernhard Fischer wrote: > Hi, > > This patchlet adds a check to configure that makes sure that we have a > working alsa setup. > > Previously, if --enable-alsa was given but the user forgot to install > the alsa libs proper, the build failed later on due to eventually > missing libs. The patch makes sure that the user can spot that alsa > support was turned off after configuration completed. This is wrong. If the user requests alsa we should honour that request, or fail trying. We should never quietly ignore an explicit user decision. Making configure fail early with an error is acceptable (as it the current link failure). Ignoring --enable-alsa is not. Paul