From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] current qemu cvs broken for mingw hosts
Date: Tue, 30 Jan 2007 22:55:25 +0000 [thread overview]
Message-ID: <200701302255.26377.paul@codesourcery.com> (raw)
In-Reply-To: <46d6db660701301209t62180911vdd8e72aee37b4acc@mail.gmail.com>
On Tuesday 30 January 2007 20:09, Christian MICHON wrote:
> On 1/30/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > just guard it with an #ifndef ENOMEDIUM
>
> this one was not bothering so much, but it's true it's cleaner with this.
>
> > > c:/qemu/qemu-30jan07/vl.c: In function `win_chr_read_poll':
> > > c:/qemu/qemu-30jan07/vl.c:2021: error: structure has no member named
> > > `chr' [...]
> > >
> > > I cannot figure out what "chr"'s type is supposed to be in the struct.
> >
> > How about CharDriverState? I deduce this from
> >
> > origin:vl.h:318:int qemu_chr_can_read(CharDriverState *s);
>
> I guess I'm tired (banged too much my head on git recently :) )
> The fix is attached: thanks.
Did you test it? I'm fairly certain it still won't work. AFAICS You're not
setting the field anywhere.
Paul
next prev parent reply other threads:[~2007-01-30 22:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 19:12 [Qemu-devel] current qemu cvs broken for mingw hosts Christian MICHON
2007-01-30 19:28 ` Johannes Schindelin
2007-01-30 20:09 ` Christian MICHON
2007-01-30 22:55 ` Paul Brook [this message]
2007-01-30 23:09 ` Johannes Schindelin
2007-01-30 23:13 ` Christian MICHON
2007-01-31 16:24 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701302255.26377.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).