From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HCEJp-0003Mo-EV for qemu-devel@nongnu.org; Wed, 31 Jan 2007 07:12:05 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HCEJn-0003MF-Lu for qemu-devel@nongnu.org; Wed, 31 Jan 2007 07:12:04 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HCEJn-0003MC-Fa for qemu-devel@nongnu.org; Wed, 31 Jan 2007 07:12:03 -0500 Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HCEJm-0005YB-WF for qemu-devel@nongnu.org; Wed, 31 Jan 2007 07:12:03 -0500 Date: Wed, 31 Jan 2007 12:07:47 +0000 Subject: Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation Message-ID: <20070131120747.GA521@networkno.de> References: <45B68307.9090509@bellard.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: From: Thiemo Seufer Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ed Swierk Cc: qemu-devel@nongnu.org Ed Swierk wrote: > Here's a revised patch with the mmap stuff removed. I'll refine the > persistence support, but in the meantime the EEPROM device is usable > even if it forgets its contents when qemu exits. It doesn't apply for current CVS. Could you please update the patch? I would also prefer to have enums instead of raw constants in all those case statements. Thiemo