qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] verbose error when /dev/kqemu can't be open
Date: Tue, 06 Feb 2007 15:08:43 -0000	[thread overview]
Message-ID: <20070206150740.GA3277@aragorn> (raw)

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]


Please can you apply this tiny patch to make /dev/kqemu open failures more
verbose?

It'll help the user distinguish between ENOENT, EPERM and ENXIO, since they
are all common causes of open failure.

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.

[-- Attachment #2: dev_error.diff --]
[-- Type: text/x-diff, Size: 508 bytes --]

--- qemu-0.8.2/kqemu.c~	2006-07-22 19:23:34.000000000 +0200
+++ qemu-0.8.2/kqemu.c	2007-02-06 16:04:58.000000000 +0100
@@ -174,7 +174,7 @@
     kqemu_fd = open(KQEMU_DEVICE, O_RDWR);
 #endif
     if (kqemu_fd == KQEMU_INVALID_FD) {
-        fprintf(stderr, "Could not open '%s' - QEMU acceleration layer not activated\n", KQEMU_DEVICE);
+        fprintf(stderr, "Could not open '%s' - QEMU acceleration layer not activated: %s\n", KQEMU_DEVICE, strerror(errno));
         return -1;
     }
     version = 0;

                 reply	other threads:[~2007-02-06 15:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070206150740.GA3277@aragorn \
    --to=rmh@aybabtu.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).