From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HERw3-0008Et-Do
	for qemu-devel@nongnu.org; Tue, 06 Feb 2007 10:08:43 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HERvz-0008Eg-VJ
	for qemu-devel@nongnu.org; Tue, 06 Feb 2007 10:08:42 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HERvz-0008Ed-Qt
	for qemu-devel@nongnu.org; Tue, 06 Feb 2007 10:08:39 -0500
Received: from aybabtu.com ([69.60.117.155])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32)
	(Exim 4.52) id 1HERvz-0002WZ-Cv
	for qemu-devel@nongnu.org; Tue, 06 Feb 2007 10:08:39 -0500
Received: from [192.168.10.6] (helo=aragorn)
	by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32)
	(Exim 4.63) (envelope-from <rmh@aybabtu.com>) id 1HERv5-0001LX-IK
	for qemu-devel@nongnu.org; Tue, 06 Feb 2007 16:07:43 +0100
Received: from rmh by aragorn with local (Exim 4.63)
	(envelope-from <rmh@aybabtu.com>) id 1HERv2-0000rq-4k
	for qemu-devel@nongnu.org; Tue, 06 Feb 2007 16:07:40 +0100
From: Robert Millan <rmh@aybabtu.com>
Message-ID: <20070206150740.GA3277@aragorn>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="jRHKVT23PllUwdXP"
Content-Disposition: inline
Subject: [Qemu-devel] [PATCH] verbose error when /dev/kqemu can't be open
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Date: Tue, 06 Feb 2007 15:08:43 -0000
To: qemu-devel@nongnu.org


--jRHKVT23PllUwdXP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


Please can you apply this tiny patch to make /dev/kqemu open failures more
verbose?

It'll help the user distinguish between ENOENT, EPERM and ENXIO, since they
are all common causes of open failure.

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.

--jRHKVT23PllUwdXP
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="dev_error.diff"

--- qemu-0.8.2/kqemu.c~	2006-07-22 19:23:34.000000000 +0200
+++ qemu-0.8.2/kqemu.c	2007-02-06 16:04:58.000000000 +0100
@@ -174,7 +174,7 @@
     kqemu_fd = open(KQEMU_DEVICE, O_RDWR);
 #endif
     if (kqemu_fd == KQEMU_INVALID_FD) {
-        fprintf(stderr, "Could not open '%s' - QEMU acceleration layer not activated\n", KQEMU_DEVICE);
+        fprintf(stderr, "Could not open '%s' - QEMU acceleration layer not activated: %s\n", KQEMU_DEVICE, strerror(errno));
         return -1;
     }
     version = 0;

--jRHKVT23PllUwdXP--