From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HFF2Q-0005S6-GH for qemu-devel@nongnu.org; Thu, 08 Feb 2007 14:34:34 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HFF2P-0005Qm-Gs for qemu-devel@nongnu.org; Thu, 08 Feb 2007 14:34:34 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HFF2P-0005QO-Av for qemu-devel@nongnu.org; Thu, 08 Feb 2007 14:34:33 -0500 Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HFF2O-00021a-OO for qemu-devel@nongnu.org; Thu, 08 Feb 2007 14:34:33 -0500 Received: from aamtaout03-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com with ESMTP id <20070208193423.OYVD2951.mtaout01-winn.ispmail.ntl.com@aamtaout03-winn.ispmail.ntl.com> for ; Thu, 8 Feb 2007 19:34:23 +0000 Received: from miranda.arrow ([213.107.21.212]) by aamtaout03-winn.ispmail.ntl.com with ESMTP id <20070208193423.SSTC26699.aamtaout03-winn.ispmail.ntl.com@miranda.arrow> for ; Thu, 8 Feb 2007 19:34:23 +0000 Received: from sdb by miranda.arrow with local (Exim 4.50) id 1HFF2D-0000Gq-JJ for qemu-devel@nongnu.org; Thu, 08 Feb 2007 19:34:21 +0000 Date: Thu, 8 Feb 2007 19:34:21 +0000 From: Stuart Brady Message-ID: <20070208193421.GA1011@miranda.arrow> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline Subject: [Qemu-devel] [PATCH] qemu-img: fix incorrect error message Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, qemu-img convert produces an incorrect error message if an unknown file format is requested for the output image. "qemu-img convert -f raw in.img -O snafu out.img" produces: qemu-img: Unknown file format 'raw' The attached patch fixes this. -- Stuart Brady --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="qemu-img-outfmt-errmsg.diff" Index: qemu-img.c =================================================================== RCS file: /sources/qemu/qemu/qemu-img.c,v retrieving revision 1.16 diff -u -r1.16 qemu-img.c --- qemu-img.c 5 Feb 2007 20:21:32 -0000 1.16 +++ qemu-img.c 8 Feb 2007 19:31:54 -0000 @@ -457,7 +457,7 @@ drv = bdrv_find_format(out_fmt); if (!drv) - error("Unknown file format '%s'", fmt); + error("Unknown file format '%s'", out_fmt); if (compress && drv != &bdrv_qcow && drv != &bdrv_qcow2) error("Compression not supported for this file format"); if (encrypt && drv != &bdrv_qcow && drv != &bdrv_qcow2) --LZvS9be/3tNcYl/X--