From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HGJYB-00021H-9e
	for qemu-devel@nongnu.org; Sun, 11 Feb 2007 13:35:47 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HGJY9-00020q-Rb
	for qemu-devel@nongnu.org; Sun, 11 Feb 2007 13:35:46 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HGJY9-00020n-L6
	for qemu-devel@nongnu.org; Sun, 11 Feb 2007 13:35:45 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HGJY8-0004Rd-Qo
	for qemu-devel@nongnu.org; Sun, 11 Feb 2007 13:35:45 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] qemu/linux-user syscall.c
Date: Sun, 11 Feb 2007 18:35:36 +0000
References: <E1HGJPa-0007tx-3l@savannah.gnu.org>
In-Reply-To: <E1HGJPa-0007tx-3l@savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200702111835.37521.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sunday 11 February 2007 18:26, Thiemo Seufer wrote:
> CVSROOT:	/sources/qemu
> Module name:	qemu
> Changes by:	Thiemo Seufer <ths>	07/02/11 18:26:54
>
> Modified files:
> 	linux-user     : syscall.c
>
> Log message:
> 	Linux userland emulation of syslog, from Debian patchset.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/syscall.c?cvsroot=qemu&
>r1=1.83&r2=1.84

>       ret = get_errno(sys_syslog((int)arg1, (char*)arg2, (int)arg3));

This is wrong. It should use lock_user_string or similar. Please fix or 
revert.

Paul