From: "M. Warner Losh" <imp@bsdimp.com>
To: sol10x86@cox.net, qemu-devel@nongnu.org
Cc: cwolsen@domainatlantic.com
Subject: Re: [Qemu-devel] FreeBSD Support
Date: Mon, 19 Feb 2007 22:14:24 -0700 (MST) [thread overview]
Message-ID: <20070219.221424.-552482231.imp@bsdimp.com> (raw)
In-Reply-To: <20894890.1171937332995.JavaMail.root@eastrmwml08.mgt.cox.net>
In message: <20894890.1171937332995.JavaMail.root@eastrmwml08.mgt.cox.net>
Ben Taylor <sol10x86@cox.net> writes:
: Start with the configure script and Makefiles, and any very specfic, targeted
: and small patches and let those changes slowly propogate out.
Most of the FreeBSD ports patches are relatively easy to justify and
explain. For example, FreeBSD port system defines SDL_CONFIG in a way
that's overridable. There's a patch that looks like:
Index: qemu/configure
@@ -204,7 +204,7 @@
if test -z "$sdl" ; then
-sdl_config="sdl-config"
+sdl_config="${SDL_CONFIG}"
sdl=no
sdl_static=no
which is straight forward enought, but still wrong... It should be:
Index: qemu/configure
@@ -204,7 +204,7 @@
if test -z "$sdl" ; then
-sdl_config="sdl-config"
+sdl_config="${SDL_CONFIG:-sdl-config}"
sdl=no
sdl_static=no
to still work on non-FreeBSD systems or on FreeBSD systems not using
the ports....
There's a lot of niggles like this, however...
Warner
next prev parent reply other threads:[~2007-02-20 5:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 2:08 [Qemu-devel] FreeBSD Support Ben Taylor
2007-02-20 2:15 ` Christopher Olsen
2007-02-20 5:14 ` M. Warner Losh [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-02-16 19:02 [Qemu-devel] QEMU: VNC Christopher Olsen
2007-02-20 0:45 ` Anthony Liguori
2007-02-20 1:05 ` Daniel P. Berrange
2007-02-20 1:15 ` [Qemu-devel] FreeBSD Support Christopher Olsen
2007-02-20 1:46 ` Paul Brook
2007-02-20 2:10 ` Christopher Olsen
2007-02-20 2:41 ` Paul Brook
2007-02-20 3:26 ` Christopher Olsen
2007-02-24 19:08 ` Juergen Lock
2007-02-24 20:54 ` Leonardo Reiter
2007-02-26 0:12 ` andrzej zaborowski
2007-03-03 22:12 ` Thiemo Seufer
2007-03-05 7:38 ` andrzej zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070219.221424.-552482231.imp@bsdimp.com \
--to=imp@bsdimp.com \
--cc=cwolsen@domainatlantic.com \
--cc=qemu-devel@nongnu.org \
--cc=sol10x86@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).