From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HJNgr-0001gD-Sp
	for qemu-devel@nongnu.org; Tue, 20 Feb 2007 00:37:25 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HJNgq-0001fN-2W
	for qemu-devel@nongnu.org; Tue, 20 Feb 2007 00:37:25 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HJNgp-0001fK-Rj
	for qemu-devel@nongnu.org; Tue, 20 Feb 2007 00:37:23 -0500
Received: from vc4-2-0-87.dsl.netrack.net ([199.45.160.85]
	helo=harmony.bsdimp.com) by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HJNgp-0002eK-AF
	for qemu-devel@nongnu.org; Tue, 20 Feb 2007 00:37:23 -0500
Date: Mon, 19 Feb 2007 22:14:24 -0700 (MST)
Message-Id: <20070219.221424.-552482231.imp@bsdimp.com>
Subject: Re: [Qemu-devel] FreeBSD Support
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20894890.1171937332995.JavaMail.root@eastrmwml08.mgt.cox.net>
References: <20894890.1171937332995.JavaMail.root@eastrmwml08.mgt.cox.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: sol10x86@cox.net, qemu-devel@nongnu.org
Cc: cwolsen@domainatlantic.com

In message: <20894890.1171937332995.JavaMail.root@eastrmwml08.mgt.cox.net>
            Ben Taylor <sol10x86@cox.net> writes:
: Start with the configure script and Makefiles, and any very specfic, targeted
: and small patches  and let those changes slowly propogate out.

Most of the FreeBSD ports patches are relatively easy to justify and
explain.  For example, FreeBSD port system defines SDL_CONFIG in a way
that's overridable.  There's a patch that looks like:

Index: qemu/configure
@@ -204,7 +204,7 @@
 
 if test -z "$sdl" ; then
 
-sdl_config="sdl-config"
+sdl_config="${SDL_CONFIG}"
 sdl=no
 sdl_static=no
 
which is straight forward enought, but still wrong...  It should be:

Index: qemu/configure
@@ -204,7 +204,7 @@
 
 if test -z "$sdl" ; then
 
-sdl_config="sdl-config"
+sdl_config="${SDL_CONFIG:-sdl-config}"
 sdl=no
 sdl_static=no
 
to still work on non-FreeBSD systems or on FreeBSD systems not using
the ports....

There's a lot of niggles like this, however...

Warner