From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HJ7WY-0004fr-5h
	for qemu-devel@nongnu.org; Mon, 19 Feb 2007 07:21:42 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HJ7WW-0004br-5Y
	for qemu-devel@nongnu.org; Mon, 19 Feb 2007 07:21:41 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HJ7WV-0004bZ-Qf
	for qemu-devel@nongnu.org; Mon, 19 Feb 2007 07:21:39 -0500
Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HJ7WV-00040X-8v
	for qemu-devel@nongnu.org; Mon, 19 Feb 2007 07:21:39 -0500
Date: Mon, 19 Feb 2007 12:23:33 +0000
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] qemu/hw ide.c
Message-ID: <20070219122333.GD1857@networkno.de>
References: <E1HIwsQ-0002x8-II@savannah.gnu.org>
	<20070219083915.GF17728@kernel.dk>
	<20070219115745.GB1857@networkno.de>
	<20070219120412.GH17728@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070219120412.GH17728@kernel.dk>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jens Axboe <qemu@kernel.dk>
Cc: qemu-devel@nongnu.org

Jens Axboe wrote:
> On Mon, Feb 19 2007, Thiemo Seufer wrote:
> > Jens Axboe wrote:
> > > On Mon, Feb 19 2007, Thiemo Seufer wrote:
> > > > CVSROOT:	/sources/qemu
> > > > Module name:	qemu
> > > > Changes by:	Thiemo Seufer <ths>	07/02/19 00:59:34
> > > > 
> > > > Modified files:
> > > > 	hw             : ide.c 
> > > > 
> > > > Log message:
> > > > 	Ignore special flags in nsector variable.
> > > > 
> > > > CVSWeb URLs:
> > > > http://cvs.savannah.gnu.org/viewcvs/qemu/hw/ide.c?cvsroot=qemu&r1=1.53&r2=1.54
> > > 
> > > Why is nsector uint32_t to begin with?
> > 
> > Because nobody sent a patch to fix it, I figure.
> 
> Actually I seem to recall it's because it's being overloaded for
> requests that are > 256 sectors. It would be a good cleanup to get rid
> of that an turn nsector into a proper uint8_t.

It appears to use 16k bits in some cases. I won't fiddle with it myself
because I know nothing about IDE and have no time to learn about it.


Thiemo