From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HJ7ZN-0006p6-7c for qemu-devel@nongnu.org; Mon, 19 Feb 2007 07:24:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HJ7ZL-0006nu-J2 for qemu-devel@nongnu.org; Mon, 19 Feb 2007 07:24:36 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HJ7ZL-0006nn-76 for qemu-devel@nongnu.org; Mon, 19 Feb 2007 07:24:35 -0500 Received: from brick.kernel.dk ([62.242.22.158] helo=kernel.dk) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HJ7ZK-0004VQ-Po for qemu-devel@nongnu.org; Mon, 19 Feb 2007 07:24:35 -0500 Date: Mon, 19 Feb 2007 13:24:24 +0100 From: Jens Axboe Subject: Re: [Qemu-devel] qemu/hw ide.c Message-ID: <20070219122424.GI17728@kernel.dk> References: <20070219083915.GF17728@kernel.dk> <20070219115745.GB1857@networkno.de> <20070219120412.GH17728@kernel.dk> <20070219122333.GD1857@networkno.de> <20070219122453.GE1857@networkno.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070219122453.GE1857@networkno.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thiemo Seufer Cc: qemu-devel@nongnu.org On Mon, Feb 19 2007, Thiemo Seufer wrote: > Thiemo Seufer wrote: > [snip] > > > > > Why is nsector uint32_t to begin with? > > > > > > > > Because nobody sent a patch to fix it, I figure. > > > > > > Actually I seem to recall it's because it's being overloaded for > > > requests that are > 256 sectors. It would be a good cleanup to get rid > > > of that an turn nsector into a proper uint8_t. > > > > It appears to use 16k bits in some cases. I won't fiddle with it myself > > 16bits, or 64k, that is. Yeah, it's for larger requests. It would be nice to track elsewhere, though. I'll take a look at it. -- Jens Axboe