Re: [Qemu-devel] [PATCH] Add -name option

["Daniel P. Berrange" <berrange@redhat.com>]

On Sun, Mar 04, 2007 at 11:11:15AM -0600, Anthony Liguori wrote:
> Avi Kivity wrote:
> >Anthony Liguori wrote:
> >>This option helps differentiate between guests when running more than 
> >>one instance of QEMU.  It adds a string to the SDL window title and 
> >>to the VNC server title.
> >>
> >>Having a name associated with a guest is also terribly useful for 
> >>management tools as it gives a standard way to identify guests to the 
> >>user.
> >>
> >> 
> >>-    vnc_write_u32(vs, 4);        -    vnc_write(vs, "QEMU", 4);
> >>+    if (qemu_name) +    size = snprintf(buf, sizeof(buf), "QEMU 
> >>(%s)", qemu_name);
> >>+    else
> >>+    size = snprintf(buf, sizeof(buf), "QEMU");
> >>+
> >
> >Perhaps in the modern style:
> >
> >   snprintf("%s - QEMU", sizeof, qemu_name)
> 
> So right now we have:
> 
> QEMU
> QEMU - Press Ctrl+Alt to exit grab
> 
> My patch would add:
> 
> QEMU (WinXP Home)
> QEMU (WinXP Home) - Press Ctrl+Alt to exit grab
> 
> You're suggesting:
> 
> WinXP Home - QEMU
> WinXP Home - QEMU - Press Ctrl+Alt to exit grab
> 
> I like yours for the first title but the SDL grab version seems a little 
> strange.  That's why I stuck it in ()s in the first place.
> 
> Anyone else have ideas?

Take 'QEMU' out of the title as it doesn't really give any useful info
compared to the name of the OS. If the user doesn't specify an explicit
name it can use the generic 'QEMU' as title, otherwise leave it out.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|